Add core module #1692
Merged
Add core module #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It seems there are some unit test errors. |
Collaborator
Author
|
They should be fixed now. |
|
🚀 Deployed on https://6505351791bdff609ccc5187--opengeos.netlify.app |
Member
|
It seems there is a bug with |
Member
|
The It appears that the drawing tools are broken.
|
Collaborator
Author
|
Were the drawing tools broken by this PR, or were they broken before? |
Member
|
It seems broken by this PR only. Before After |
Collaborator
Author
|
I'll take a look. Thanks! |
Collaborator
Author
|
a21094d fixed the drawing tool issues. |
Member
|
@naschmitz Excellent work! This is a major milestone. Excited to see the creation of the core module. I have tested it and everything seems working properly. I only made some minor changes.
|
giswqs
approved these changes
Sep 16, 2023
jgarcia525
pushed a commit
to jgarcia525/geemap
that referenced
this pull request
Sep 19, 2023
* Clean up layer management ivars. * Add core module. * Fix unit tests after layer counting update. * Fix unit tests after query_widgets rename. * Fix authentication in unit tests. * Fix ee_initialize bug * Add basic core unit tests. * Fix bad EE initialization in core tests. * Fix adding EELeafletTileLayers to the map. * Enable scroll wheel zoom by default * Add module to mkdocs * Add md files and addLayer backward compatibility --------- Co-authored-by: Qiusheng Wu <[email protected]>
jgarcia525
pushed a commit
to jgarcia525/geemap
that referenced
this pull request
Sep 20, 2023
* Clean up layer management ivars. * Add core module. * Fix unit tests after layer counting update. * Fix unit tests after query_widgets rename. * Fix authentication in unit tests. * Fix ee_initialize bug * Add basic core unit tests. * Fix bad EE initialization in core tests. * Fix adding EELeafletTileLayers to the map. * Enable scroll wheel zoom by default * Add module to mkdocs * Add md files and addLayer backward compatibility --------- Co-authored-by: Qiusheng Wu <[email protected]>
This was referenced Sep 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API will evolve over the next couple weeks. No need to add to the documentation.
I will add unit tests later.