Skip to content

Fix layer visualization GUI bug #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giswqs merged 1 commit into from
Aug 31, 2023
Merged

Fix layer visualization GUI bug #1687

giswqs merged 1 commit into from
Aug 31, 2023

Conversation

@giswqs
Copy link
Member

@giswqs giswqs commented Aug 31, 2023

Fix #1686

The refactoring in #1671 added the following function to invoke the layer visualization GUI. However, button.tooltip was not initialized when creating buttons, resulting in no action when the button is clicked. This PR fixes this bug.

@naschmitz

    def _on_layer_settings_click(self, button):
        if self.on_open_vis:
            self.on_open_vis(button.tooltip)

Peek 2023-08-31 13-30

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

🚀 Deployed on https://64f0d0fe5a995613718543f3--opengeos.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 31, 2023 17:42 Inactive
@giswqs giswqs merged commit e29a067 into master Aug 31, 2023
@giswqs giswqs deleted the layer-vis branch August 31, 2023 17:43
@giswqs giswqs mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Layer visualization GUI not working

2 participants

@giswqs