Refactor inspector into an ipywidgets subclass #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for refactoring. Overall, it looks good to me. One small bug is that it stucks when clicking at a location that is not covered by all layers. import ee
import geemap
Map = geemap.Map(center=(40, -100), zoom=4)
dem = ee.Image('USGS/SRTMGL1_003')
states = ee.FeatureCollection("TIGER/2018/States")
vis_params = {
'min': 0,
'max': 4000,
'palette': ['006633', 'E5FFCC', '662A00', 'D8D8D8', 'F5F5F5'],
}
Map.addLayer(dem, vis_params, 'SRTM DEM', True, 0.5)
Map.addLayer(states, {}, "US States")
Map.add_inspector()
Map
|
giswqs
reviewed
Aug 15, 2023
| else: | ||
| return Tree(nodes=[root_node]) | ||
|
|
||
| def _objects_info(self, latlon, names=None, visible=True, return_node=False): |
There was a problem hiding this comment.
The refactored _object_info() function only has the latlon parameter, missing the names and visible parameters. The bug occurs when the mouse-clicking location does not interact the feature collection.
giswqs
reviewed
Aug 15, 2023
| else: | ||
| return Tree(nodes=[root_node]) | ||
|
|
||
| def _pixels_info( |
There was a problem hiding this comment.
Similarly, the refactored _pixels_info() function only has the latlon parameter. It also causes issues when clicking at locations without pixels.
|
I'll take a look. I think I know what's happening. It's likely due to removing some exception handling code when doing the EE computations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.