refactor basemaps #1075
Merged
refactor basemaps #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided to use values and items method from dictionaries to loop inside them. First advantage is to reduce the length of the call and remove some useless lines Second advantage is that it's clearer what `key` and `item` represent in the dict
using pop was dropping the max_zoom for all the layers
|
This pull request introduces 1 alert when merging 077c8b2 into c219cd8 - view on LGTM.com new alerts:
|
|
Looks great! Many thanks for improving the code quality. Much appreciated. |
|
I just noticed that the refactored def get_xyz_dict(free_only=True, _collection=xyz, _output={}):def get_xyz_dict(free_only=True, _collection=None, _output=None)
|
|
Oops sorry, glad to see that this modification was sufficient. I'm using Shinx and autodoc for my libs and parameter/members/methods/functions prefixed by a "_" are ignored. I thought it was the same on your side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loops in dict
I decided to use values and items method from dictionaries to loop inside them.
keyanditemrepresent in the dictget_xyz_dict
I used a more pythonic recursive function to retreive everything. Cherry on the cake it's way faster (1.1 ms on my machine).
PS
I did the modification on the fly in GitHub as I was passing by, I think it will require some testing before merging I may have done typos