Add Dart support #3973
Merged
Add Dart support #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
b4n
reviewed
Oct 6, 2024
There was a problem hiding this comment.
LGTM from little review and testing apart from:
- the comment about the patch file
- the absence of tags parsing. the custom filetype version uses Java, which seems to do a decent job (beware that not knowing the language, I just copied a couple of samples and lanced at the results), should this one do the same?
This is what I wanted to test but then forgot about it. I'll add it. |
This PR adds support for the Dart language: 1. It uses the Dart lexer which has been recently merged to lexilla 2. The keywords are based on Notepad4 keywords 3. Build menu settings is based on geany#371
|
@b4n I've rebased this PR on top of master, resolved conflicts and updated build commands based on #371 (comment) (I didn't receive any feedback there but I think it can be easily modified if users report problems with them). Is it alright to merge this PR? |
b4n
approved these changes
Nov 10, 2024
This was referenced Nov 10, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Dart language: