Add Nix support #3954
Merged
Add Nix support #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm checking in more daily use now |
|
Talked with Frank in person today and it seems to work for him so submitting upstream. |
|
I've updated the lexer to the version merged into Lexilla. This PR is completed from my perspective. |
|
Alright, I rebased this PR on top of master, re-checked the patch, re-tested and everything seems to be all right. So unless there are any objections, I'll merge it in about a week. |
b4n
reviewed
Nov 24, 2024
b4n
reviewed
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@frlan Christmas ;-)
This is a work-in-progress Nix lexer I plan to submit to Lexilla but I'd like some feedback from @frlan as he's the most proficient Nix user around. Things should mostly work, I'm just aware of a problem regarding folding when a block ends and is followed by a multiline string on the same line:
This is something I have to ask Neil how to handle the best way.
Otherwise I'm not aware of any other issues and I'm interested in any problems that appear. Especially if strings, escaping, and string interpolations work as expected and in general if the highlighting seems correct or something is missing.
Also, for now, the config file doesn't contain correct build commands - @frlan eventually this is something I'll need from you for Geany.