Use pipe characte3r instead of new-line to protect substitution parameters #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It tried to process a file (locales/en.msg) that has been removed.
Default strings were loaded even after a successful load of the catalog file. The error type variable was always loaded from the non-NLS string.
…hanges The error type is no longer concatenated from 2 strings. Remove files without region (de.*): only de_AT.*, de_CH.*, and de_DE.* are to be used.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 16 16
Lines 3080 3080
=======================================
Hits 3079 3079
Misses 1 1Continue to review full report at Codecov.
|
|
Looks good. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of \n in a substitution operation in sed is not portable.
I suggest to use a pipe character, which is highly unlikely to occur in a valid path name.
Another option might be to use a colon for this purpose, since it is guaranteed not to occur in the locale path specification (since it is used to separate multiple such pathes in $NLSPATH).