Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          16       16           
  Lines        3478     3478           
=======================================
  Hits         3468     3468           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cc514...96518d8. Read the comment docs.

Yes, you did find a bug.

Your fix looks great, and your tests do as well. I just have two requests:

1. Move your tests and results into files called comp.txt and comp_results.txt.
2. Change the name in tests/bc/all.txt.

I want you to do this because I am going to write a more comprehensive set of tests for comparisons in general to make sure I did not miss anything else.

If you don't have the time to do this, I could always pull it and do the change myself.

Just finished, thank you.

BTW it looks like busybox guys took your code and kept the bug in their modified version.
Just fixed it there as well: https://bugs.busybox.net/show_bug.cgi?id=12336

Then it should be fixed in Alpine (that's where I encountered it this morning).

busybox didn't exactly take my code; I gave them my code, when it had a lot more bugs as well. Unfortunately, they decided to go their own way with it, so I don't really contribute back. (They added even more bugs.)

I will merge this when I get home from work. I should have a release out after testing, which could take up to a week. I don't expect this to take that long to test, since it's so small, but I may find other problems.

I pulled manually. Thank you for your help!