Small performance optimization (perhaps for the next following release?) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks show a small but significant speed-up of "make test" if the limit for the shifting of operands is made more strict. Many operands will require a second iteration of the inner loop anyway, and shifting of the operands uses cycles for no gain, then. To my surprise, BC_BASE_DIGS=4 and =9 seem to have near identical performance after this change. Some operations (multiplication and power) ought to be faster with larger BcDigs, but at least for the performance of "make test" on my system this does not seem to affect the run-time by a significant amount.
|
I am not planning on future releases, except for bug fixes. I will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show a small but significant speed-up of "make test" if the
limit for the shifting of operands is made more strict. Many operands
will require a second iteration of the inner loop anyway, and shifting
of the operands uses cycles for no gain, then.
To my surprise, BC_BASE_DIGS=4 and =9 seem to have near identical
performance after this change. Some operations (multiplication and
power) ought to be faster with larger BcDigs, but at least for the
performance of "make test" on my system this does not seem to affect
the run-time by a significant amount.