Install real catalog files first, then links for alias names. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 16 16
Lines 3081 3081
=======================================
Hits 3080 3080
Misses 1 1Continue to review full report at Codecov.
|
|
There is a change that could be made to make this more robust in the case that the locale that is linked to wasn't installed, but I will make that later. Merged. |
gavinhoward
pushed a commit
that referenced
this pull request
May 5, 2021
This bug was reported in https://git.yzena.com/gavin/bc/issues/10. It happens when the first thing a user enters at `stdin` causes a parse error. mathieu did not know what caused the error, and I could not reproduce it on my machine. I tried on FreeBSD and could reproduce it under root, but not my user. After investigating, the reason I could not reproduce it was because my user runs a file: /home/gavin/.bcrc. Because it runs the file, it would execute the `scale = 20` statement in the math library. However, when I would not have it execute that file, and enter a parse error first, that statement would not be executed, and since bc resets after an error, that statement would disappear and never happen. The fix was simple: just call bc_program_exec() right after loading the math libraries. Fix #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion of an alternate installation sequence for catalog files.
First the "real" files are installed, then (hard) links added to provide the aliases.
Since all catalog files should be on the same file system, the use of hard links should be OK ...