Update custom CAs on existing nodes #10923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/ops-productivity
gardener-prow
bot
added
the
size/M
oliver-goetz
force-pushed
the
enh/update-ca-on-existing-nodes
branch
from
d951edc to
804edb1
Compare
|
LGTM label has been added. Git tree hash: b730137b722868f4e5293172302876bd51da3003
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
nschad
added a commit
to stackitcloud/gardener
that referenced
this pull request
Feb 3, 2025
This reverts commit b88242d.
ske-prow bot
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Feb 3, 2025
This reverts commit b88242d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ops-productivity
/kind enhancement
What this PR does / why we need it:
At the moment custom CAs are applied when the node is created only. Existing nodes are not updated.
This PR changes this behavior and allows updating custom CAs on existing nodes. It is possible to restart containerd without restarting all containers (ref) which was not the case for docker. As Gardener does not support Docker anymore, this change is possible now.
When custom CAs change
containerdandkubeletservices are restarted on the node.Other services affected by CA changes like
gardener-node-agent(ref) andvalitail(ref) already include the CA bundle in their configuration or as own file, so they are restarting already.Which issue(s) this PR fixes:
Fixes #10040
Special notes for your reviewer:
Release note: