Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up HVPA usages from Roles and Clusterroles and removes HVPA CRDs #10921

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Cleans up HVPA usages from Roles and Clusterroles and removes HVPA CRDs #10921

merged 7 commits into from
Nov 28, 2024

Conversation

plkokanov
Copy link
Contributor

@plkokanov plkokanov commented Nov 26, 2024 •
edited
Loading

How to categorize this PR?

/area auto-scaling
/kind cleanup

What this PR does / why we need it:
This PR is the 6th PR related to the HVPA removal. The first 5 PRs were:

  1. Remove no longer used autoscaling modes for {gardener,kube}-apiserver #10796
  2. Remove HVPA from etcd component and only use VPA for autoscaling #10800
  3. Clean up the hvpa component and its usages #10851
  4. Clean up the HVPA, HVPAForShootedSeed, VPAForETCD and VPAAndHPAForAPIServer feature gates #10853
  5. resource-manager: Clean up HVPA usages and mutations #10860

This PR cleans up remaining HVPA usages:

  • Removes HVPA from the clusterroles and roles used by gardenlet and gardener-operator
  • Removes HVPA from the seed and operator client schemes
  • Removes the HVPA CRD
  • Cleans up go imports

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
This pr is rebased on top of #10860 so I will keep it in draft until that one gets merged.

Release note:

The `autoscaling.k8s.io/v1alpha1.Hvpa` and `autoscaling.k8s.io/v1alpha1.HvpaList` resources were removed from the `pkg/client/kubernetes.SeedScheme` and `pkg/operator/client.RuntimeScheme`   

The `HVPA` CRD has been removed from the codebase and is no longer generated.

RBAC rules related to `HVPA` resources have been removed from `gardenlet` and `gardener-operator` - they are no longer necessary.

@gardener-prow gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/cleanup Something that is not needed anymore and can be cleaned up labels Nov 26, 2024
@gardener-prow gardener-prow bot requested review from acumino and rfranzke November 26, 2024 07:53
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2024
@ialidzhikov
Copy link
Member

/assign

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@plkokanov plkokanov force-pushed the cleanup/hvpa-resources branch from e50bfd4 to 2ec278b Compare November 28, 2024 14:04
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2024
rfranzke
rfranzke reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

LGTM label has been added.

Git tree hash: c15bd05160923893cdb9c15c6ad078f1385a53d1

@plkokanov plkokanov marked this pull request as ready for review November 28, 2024 14:17
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2024
ialidzhikov
ialidzhikov approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@ialidzhikov
Copy link
Member 

Error: bad file 'hack/../example/gardener-local/gardenlet/operator/patch-imagevector-overwrite.yaml': yaml: line 13: could not find expected ':'
Build [local-skaffold/gardenlet] failed: exit status 1

/test pull-gardener-e2e-kind-ha-multi-zone

@ialidzhikov
Copy link
Member 

  [FAILED] Timed out after 30.001s.
  The function passed to Eventually failed at /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/seed/renew_garden_access_secrets.go:131 with:
  Expected
      <map[string]string | len:2>: {
          "provider-local-e2e-test-garden-access": "2024-11-28T14:30:48Z",
          "gardener.cloud/operation": "renew-garden-access-secrets",
      }
  not to have key
      <string>: gardener.cloud/operation
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/seed/renew_garden_access_secrets.go:132 @ 11/28/24 14:31:03.903

/test pull-gardener-e2e-kind

@gardener-prow gardener-prow bot merged commit e458bc0 into gardener:master Nov 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@acumino acumino Awaiting requested review from acumino

@LucaBernstein LucaBernstein Awaiting requested review from LucaBernstein

@tobschli tobschli Awaiting requested review from tobschli

Assignees

@ialidzhikov ialidzhikov

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plkokanov @ialidzhikov @rfranzke