Add support for node-local-dns in dual-stack cluster.
#10891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-local-dns accepts only one ip-family as localip. We only use addresses of the primary ipfamily. Queries to address of the secondary ipfamily of the service would not be cached.
gardener-prow
bot
added
area/networking
gardener-prow
bot
added
the
size/L
ScheererJ
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Thanks for mitigating dual-stack support for node-local-dns while we wait for kubernetes/dns#655 and kubernetes/dns#657 to be resolved.
|
/assign |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 01fc1e70999bf31bde180b0c53eaa2cbab863bcf
|
ScheererJ
approved these changes
Nov 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-local-dnsaccepts only one ip-family as localip. With this PR, we only use addresses of the primary ipfamily.Queries to address of the secondary ipfamily of the service would not be cached.
How to categorize this PR?
/area networking
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: