Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vertical-pod-autoscaler directory as root for each image build #324

Conversation

plkokanov
Copy link

@plkokanov plkokanov commented Aug 15, 2024

What this PR does / why we need it:
The Dockerfiles in the corresponding vpa directories (recommender, updater and admission-controller) are written so that vertical-pod-autoscaler has to be used as work directory:

RUN CGO_ENABLED=0 LD_FLAGS=-s GOARCH=$TARGETARCH GOOS=$TARGETOS go build -C pkg/recommender -mod vendor -o recommender-$TARGETARCH

Notice the go build -C pkg/recommender part from this line.

This PR tries to adapt the pipeline_definitions to that

In the corresponding Makefiles the docker command is invoked as follows:

docker buildx build --pull --load --platform linux/$* -t ${REGISTRY}/${FULL_COMPONENT}-$*:${TAG} -f ./Dockerfile ../../

This command is called from e.g. vertical-pod-autoscaler/pkg/updater, so notice the ../../ at the end

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Release note:

NONE

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2024
@plkokanov plkokanov force-pushed the fix/pipeline-definitions branch from 845c9fe to 4860324 Compare August 15, 2024 13:24
@plkokanov plkokanov marked this pull request as ready for review August 15, 2024 13:31
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ialidzhikov ialidzhikov merged commit 2a62bbe into gardener:rel-vertical-pod-autoscaler Aug 15, 2024
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants