fix(MULTIPLE-API-CALLS) merge multiple upload-api calls into one #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shruti3004
requested changes
Aug 11, 2022
| @@ -44,11 +42,9 @@ import { | |||
|
|
|||
| // Helper function for error handling | |||
| import { handleError } from "shared/helper"; | |||
| import messages from "../../../constants/messages"; | |||
There was a problem hiding this comment.
Can directly be imported like:
import messages from "constants/messages";
|
@dushimsam can you also fix test cases |
|
ok , I'm on it. |
dushimsam
force-pushed
the
dushimsam/fix/upload/multiple-calls
branch
from
9c5c27b
to
3e1f574
Compare
|
tested and working perfectly. |
Signed-off-by: dushimsam <[email protected]>
dushimsam
force-pushed
the
dushimsam/fix/upload/multiple-calls
branch
from
3e1f574
to
cb840f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dushimsam [email protected]
Description
Merge the create upload API and create job API into one API request.
Changes
How to test
How to test
1. Upload Request
Fill up the input details on Vcs Upload Page for the upload click the upload button
hence the request should look as follows.
2. Response
You should see this response object with the ID of the corresponding job in the message.
Related issue
closes : Shruti3004/FOSSology-REST-API#2 ,#260
cc: @shaheemazmalmmd @GMishx