Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multimeter UI fix #543

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Multimeter UI fix #543

merged 1 commit into from
Aug 31, 2019

Conversation

Pipe-Runner
Copy link
Contributor

@Pipe-Runner Pipe-Runner commented Aug 31, 2019 •
edited
Loading

#514

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Feature implementation
  • Doc updates
  • What changes have you introduced?
  • Multimeter dial more responsive
  • Angles now match android
  • Add background lines for multimeter and adjust the height of the component.

  • Does this PR introduce a breaking change?
    No

  • Preview / Steps to verify your work:
    2019_08_31_21_37_31

I could not find the digital font on Google fonts, so, for now, I have not made that change. Will raise another issue for this later on.

@Pipe-Runner Pipe-Runner changed the title Multimeter UI fix Multimeter UI fix [WIP] Aug 31, 2019
@Pipe-Runner Pipe-Runner changed the title Multimeter UI fix [WIP] Multimeter UI fix Aug 31, 2019
@Pipe-Runner Pipe-Runner removed the request for review from ojasgulati August 31, 2019 16:09
@mariobehling mariobehling merged commit 524790c into fossasia:development Aug 31, 2019
cynthi8 pushed a commit to cynthi8/pslab-desktop that referenced this pull request Dec 16, 2020
@Pipe-Runner @cynthi8
Multimeter UI improved (fossasia#543)
af997e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pipe-Runner @mariobehling