Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings page created #539

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Settings page created #539

merged 1 commit into from
Aug 31, 2019

Conversation

Pipe-Runner
Copy link
Contributor

@Pipe-Runner Pipe-Runner commented Aug 30, 2019 •
edited
Loading

#526

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Feature implementation
  • Doc updates
  • What changes have you introduced?
  • Settings page added

  • Does this PR introduce a breaking change?
    NO

  • Preview / Steps to verify your work:
    2019_08_30_19_57_31
    2019_08_30_19_57_29

@Pipe-Runner Pipe-Runner changed the title Settings page created [WIP] Settings page created Aug 30, 2019
mariobehling
mariobehling requested changes Aug 30, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the screenshot to the Readme.md. Please only show the app (no top or bottom of your OS).

@Pipe-Runner
Copy link
Contributor Author

Please add the screenshot to the Readme.md. Please only show the app (no top or bottom of your OS).

@mariobehling Done. Removed bars from earlier screenshot as well

@mariobehling mariobehling merged commit 8595c82 into fossasia:development Aug 31, 2019
cynthi8 pushed a commit to cynthi8/pslab-desktop that referenced this pull request Dec 16, 2020
@Pipe-Runner @cynthi8
Settings page added (fossasia#539)
74b9e81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pipe-Runner @mariobehling