Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular loading removed from data logger #530

Merged
merged 1 commit into from
Aug 30, 2019
Merged

circular loading removed from data logger #530

merged 1 commit into from
Aug 30, 2019

Conversation

Pipe-Runner
Copy link
Contributor

#525 #526

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Feature implementation
  • Doc updates
  • What changes have you introduced?
  • Settings icon removed
  • data logger loading animation removed
  • Does this PR introduce a breaking change?
    No

  • Preview / Steps to verify your work:
    2019_08_29_14_27_55

@Pipe-Runner Pipe-Runner changed the title circular loading removed from data logger, settings icon removed circular loading removed from data logger Aug 30, 2019
@mariobehling
Copy link
Member

Thanks! FYI: By the way, this PR is a good example how Github counts code contributions. Some lines were moved and they count it as lines contributed.

@mariobehling mariobehling merged commit 7cc55f4 into fossasia:development Aug 30, 2019
@Pipe-Runner
Copy link
Contributor Author

@mariobehling Thanks for letting me know,I clearly overestimated my contributions. I try to work harder.

cynthi8 pushed a commit to cynthi8/pslab-desktop that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants