Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#507] Screenshot updated, maintainer added #508

Merged
merged 1 commit into from
Aug 30, 2019
Merged

[#507] Screenshot updated, maintainer added #508

merged 1 commit into from
Aug 30, 2019

Conversation

Pipe-Runner
Copy link
Contributor

#507

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Feature implementation
  • Doc updates
  • What changes have you introduced?
  • Updated docs
  • Does this PR introduce a breaking change?
    No

@Pipe-Runner Pipe-Runner requested review from mariobehling and CloudyPadmal and removed request for mariobehling August 27, 2019 17:09
mariobehling
mariobehling reviewed Aug 27, 2019
View reviewed changes
README.md

### 8. Data logger
Data can be captured and saved in a CSV file. We also have a playback feature in place that lets the user replay the data from the CSV file.
<img src="./docs/images/data_logger.jpg" width="700px"/>

## Screenshots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the description from above directly into the table below the screenshot image. No need to make it into headings though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where? There is no description - right below the images? Please also ensure the table fits into the width of the GitHub display box.

@Pipe-Runner
Copy link
Contributor Author

Oh.. I thought u meant description in the table below the images... I got it... I l'll add captions to the images

@Pipe-Runner
Copy link
Contributor Author

@mariobehling Screenshot description added
screenshot-localhost_6419-2019 08 29-23_32_14

If this looks fine, please merge it.

@mariobehling mariobehling merged commit 1032a5e into fossasia:development Aug 30, 2019
@CloudyPadmal CloudyPadmal mentioned this pull request Sep 23, 2019
Closed
2 tasks
cynthi8 pushed a commit to cynthi8/pslab-desktop that referenced this pull request Dec 16, 2020
@Pipe-Runner @cynthi8
Screenshot updated, maintainer added (fossasia#508)
db92ebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@CloudyPadmal CloudyPadmal Awaiting requested review from CloudyPadmal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pipe-Runner @mariobehling