Temporary Fix: change height and padding of podcast and form footer #20826
Conversation
morfenza
requested review from
lightalloy and
maestromac
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20826 ⚙️ Updating now by workflow run 8540579994. What is Uffizzi? Learn more! |
app/assets/stylesheets/shared.scss
Outdated
| @@ -11,7 +11,7 @@ | |||
| #progressBar { | |||
| color: #fff; | |||
| width: 100%; | |||
| height: calc(48px + 1vh); | |||
| height: calc(43px + 1vh); | |||
There was a problem hiding this comment.
@morfenza I would advice you to either define a custom variable (e.g. --progress-bar-height: xx ) here or use of the properties available on stylesheets/config/variables and apply them in all of these instances
Plus, I think you might want to remove the +1vh and calc function if you want to keep the same height, otherwise check how it looks on mobile or other viewports.
There was a problem hiding this comment.
Nice suggestion, I'll try to implement it! Thanks! <3
morfenza
force-pushed
the
fix/podcast-layout-problem-with-publish-tools
branch
from
d0cfe6b
to
bb9fc16
Compare
What type of PR is this? (check all applicable)
Description
As described in the issue there is a visual "glitch" of sorts when listening to a podcast and creating a post, the podcast bar can make it difficult to press the "Publish" button.
I've decided to make a temporary fix while a more sophisticated solution is found.
Temporary fix:
SUGGESTION
Admins, please create an issue to implement a new feature: minimize the podcast bar, button " - ", this hide feature will conceil the progress bar, leaving only the play button and the maximize button e.g: " > "
When minimized:
Related Tickets & Documents
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
[optional] What gif best describes this PR or how it makes you feel?