Fix: change height and object fit attributes #20246 #20711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-lourenco
requested review from
lightalloy and
maestromac
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
It might be better to use aspect ratio for this &__image {
display: block;
margin: auto;
max-width: 100%;
height: auto;
object-fit: cover;
aspect-ratio: 50 / 21;
max-height: calc(
100vh - var(--header-height) - 2 * var(--layout-padding)
);
/* rest of code as normal */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Changes the attributes
object-fitandmax-heightfor.crayons-article__cover__imagein app/stylesheets/views/articles.scss, the cover image now behaves as expected. Although it is one solution I'd like to discuss possible alternatives!Related Tickets & Documents
QA Instructions, Screenshots, Recordings
System Specs:
Before the change:
After the change:
Added/updated tests?