Skip to content

feat: Improve eslint-configs#61

Open
karannakra wants to merge 5 commits intomainfrom
feat--improve-eslint-v2
Open

feat: Improve eslint-configs#61
karannakra wants to merge 5 commits intomainfrom
feat--improve-eslint-v2

Conversation

@karannakra
Copy link

@karannakra karannakra commented May 25, 2023 •
edited
Loading

Ticket Link 10

Pull Request 🚀

🏆 PR Goals 🏆

  • Add jsx-a11y and jsonc eslint plugins
  • Add recommended eslint configs
  • Fix all error introduced by eslint configs
  • Fix all warnings introduced by eslint configs

Changes Description 📝

After introducing suggested ESlint configuration, we relocated several of the rules intro override blocks because they weren't working.

Some ESlint rules that are no longer required have been removed.

Note ‼️

This PR Should be merged after this 👉🏻 👉🏻 #103

Getting this warning after running the lint script. looks minor

image

@vercel
Copy link

vercel bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
b2b-saaskit ✅ Ready (Inspect) Visit Preview Jun 30, 2023 7:51am

@github-actions
Copy link

github-actions bot commented May 25, 2023 •
edited
Loading

Uh oh! ESLint found some issues. Please run yarn fix and commit the changes.

@karannakra karannakra force-pushed the feat--improve-eslint-v2 branch from 9ef647b to 8ea12e5 Compare May 25, 2023 21:37
@karannakra karannakra force-pushed the feat--improve-eslint-v2 branch from 8ea12e5 to 1b03537 Compare May 25, 2023 21:52
@karannakra karannakra force-pushed the feat--improve-eslint-v2 branch from 1b03537 to 54a56e4 Compare June 25, 2023 13:29
@karannakra karannakra force-pushed the feat--improve-eslint-v2 branch from 54a56e4 to d459173 Compare June 25, 2023 15:09
@karannakra2
add eslint-plugin-jsonc, eslint-plugin-jsx-a11y
5956ed2
@karannakra2
extends recommended-requiring-type-checking plugin for .astro,.ts,.ts…
26cc078 
…x files

move global rules which are throwing error after extending into concerned override blocks
@karannakra karannakra force-pushed the feat--improve-eslint-v2 branch from d459173 to ec99684 Compare June 30, 2023 07:43
@karannakra karannakra force-pushed the feat--improve-eslint-v2 branch from ec99684 to 110f00c Compare June 30, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karannakra @karannakra2