Display Features support (Foldable and Cutout) #24756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2021
|
@GaryQian can you give it a look? |
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
|
@chinmaygarde could you take another look when you get a chance? |
|
I think this looks fine after Gary's review. There is a conflict but we should land this once this is resolved. |
# Conflicts: # shell/platform/android/test/io/flutter/embedding/engine/renderer/FlutterRendererTest.java
Resolved the conflict. |
chinmaygarde
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
|
|
Triggered another ci run |
|
@chinmaygarde The tree is green and this can land now, the tag you added was removed automatically due to a flaky build. |
GaryQian
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
zanderso
added a commit
that referenced
this pull request
Sep 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
|
FYI @andreidiaconu Looks like this was reverted due to failures rolling this into flutter framework: flutter/flutter#89430 (comment) Revert is: #28447 |
|
I know and am currently working on fixing it in a separate branch of the
framework repo. Most of the ci steps fail due to gradle dependency lock
files. Might get it solved over the weekend and will update you when we can
try to land it again.
If you have any guidance please let me know. Thank you!
…On Fri, 3 Sep 2021 at 22:30 Gary Qian ***@***.***> wrote:
FYI @andreidiaconu <https://github.com/andreidiaconu> Looks like this was
reverted due to failures rolling this into flutter framework: flutter/flutter#89430
(comment)
<flutter/flutter#89430 (comment)>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24756 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKWJPQMJN4NTDL3FW7V7R3UAEO3RANCNFSM4YRRSZFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This was referenced Sep 5, 2021
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for foldable devices and display cutouts, in the form of Display Features.
A display feature is an area of the display that is obstructed by a hardware feature. For now, this works only on Android. There are three types of display features:
Here is a preview of what this PR enables, on a dual-screen emulator:
Issues that will be closed by this PR:
Work in progress: