[fix] Allow negative %/vh/vw offsets #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
force-pushed
the
fix-negative-offsets
branch
from
bc4269d
to
93a6a72
Compare
shmax
reviewed
Apr 23, 2017
| const refBottom = reference.getBoundingClientRect().bottom; | ||
| const refWidth = reference.offsetWidth; | ||
| const refHeight = reference.offsetHeight; | ||
| const popperLeft = popper.getBoundingClientRect().left; |
There was a problem hiding this comment.
You could have done a single call to getBoundingClientRect, no?
There was a problem hiding this comment.
That's just a test and I don't care about performance in the code I write in the tests, but I agree it would have been cleaner.
There was a problem hiding this comment.
Ah, so it is. Yeah, I don't care about performance in tests, either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a bug that prevented to use a negative offset value, e.g.
-50%.