fix: Transpile to ES5 the module bundle
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
force-pushed
the
fix-219
branch
2 times, most recently
from
82608a3
to
e850b05
Compare
|
Going to merge this because ended up we need this as well in our own code base, eheh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #219
Now the
distfolder has in the top directory, the ESM + ES6 code.In the
dist/esmfolder there's the ESM + ES5 code.In
dist/umdthere's the UMD + ES5 code.mainisdist/umd/popper.jsandmoduleisdist/esm/popper.js/cc @treshugart for review