Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cardinality test error #334

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Fix cardinality test error #334

merged 5 commits into from
Apr 16, 2021

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Feb 10, 2021 •
edited
Loading

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

418278c changed from group by 1 to group by {{ column_name }} to add t-sql support.

Table b's column name should be field instead - if its name doesn't happen to be the same column name as table a, you get an error.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@joellabes joellabes requested a review from clrcrl as a code owner February 10, 2021 03:52
@joellabes
Copy link
Contributor Author

@clrcrl can you let me know what failed with the integration test please? I've tested the fix against my project and it worked, so I must have misconfigured something in the integration tests

@joellabes
Copy link
Contributor Author

joellabes commented Feb 24, 2021 •
edited
Loading

@ Yan Karklin set me right! 🎉 Had forgotten to include the package's name (I forgot that the integration test project was different to the utils project)

@clrcrl clrcrl changed the base branch from master to dev/0.7.0 April 16, 2021 18:33
@clrcrl
Copy link
Contributor

clrcrl commented Apr 16, 2021

Changing over to dev/0.7.0 to avoid another 0.6.x release :)

@clrcrl clrcrl merged commit 56ef1d2 into dbt-labs:dev/0.7.0 Apr 16, 2021
@joellabes joellabes deleted the fix-cardinality-test branch April 16, 2021 20:00
@joellabes joellabes mentioned this pull request May 7, 2021
Closed
11 tasks
clrcrl pushed a commit that referenced this pull request May 18, 2021
@clrcrl
Fix cardinality test error (#334)
4b9328a
clrcrl pushed a commit that referenced this pull request May 18, 2021
@clrcrl
Fix cardinality test error (#334)
6c1abd3
clrcrl pushed a commit that referenced this pull request May 18, 2021
@clrcrl
Fix cardinality test error (#334)
835ae14
clrcrl pushed a commit that referenced this pull request May 18, 2021
@clrcrl
Fix cardinality test error (#334)
8bb8cef
@clrcrl clrcrl mentioned this pull request May 18, 2021
Merged
clrcrl pushed a commit that referenced this pull request May 18, 2021
@clrcrl
Fix cardinality test error (#334)
49b56a3
@jtcohen6 jtcohen6 mentioned this pull request Jun 6, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clrcrl clrcrl Awaiting requested review from clrcrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joellabes @clrcrl