Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cardinality test error #334

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Fix cardinality test error #334

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ba048e
group by field, not column_name
Feb 10, 2021
427aa45
Add integration tests and update changelog
Feb 10, 2021
d9e7986
Forgot the refs on integration tests
Feb 10, 2021
25308c6
Provide package names in integration tests
Feb 24, 2021
59788a0
Merge branch 'dev/0.7.0' into fix-cardinality-test
Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
group by field, not column_name
  • Loading branch information
Joel Labes committed Feb 10, 2021
commit 4ba048ec2819f3ac6568cd6b4754f5bd92cd6bba
2 changes: 1 addition & 1 deletion macros/schema_tests/cardinality_equality.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ select
{{ field }},
count(*) as num_rows
from {{ to }}
group by {{ column_name }}
group by {{ field }}
),

except_a as (
Expand Down