add completion for btrbk #10752
Merged
add completion for btrbk #10752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
completions for btrbk https://github.com/digint/btrbk/
Contributor
EmilyGraceSeville7cf
left a comment
EmilyGraceSeville7cf
left a comment
There was a problem hiding this comment.
Please tell me whether you were satisfied with my review. 😄
| end | ||
|
|
||
| # options with arguments | ||
| complete -c btrbk -l format -x -d 'Change output format' -a "table long raw" |
Contributor
There was a problem hiding this comment.
AFAIS, --format is allowed just before any subcommand. I would rather add -n flag to complete to restrict when --format is shown, as well as other options falling in this category.
My comment is based on this man page:
btrbk [-h|--help] [--version]
[-c|--config <file>] [-n|--dry-run] [--exclude <filter>]
[-p|--preserve] [--preserve-snapshots] [--preserve-backups]
[-v|--verbose] [-q|--quiet] [-l|--loglevel <level>]
[-t|--table] [-L|--long] [-1|--single-column]
[--format <output-format>] [--pretty]
[-S|--print-schedule] [--progress]
[--lockfile <file>]
[--override <config_option>=<value>]
<command> [[--] <filter>...]
Member
|
Thanks! |
zanchey
pushed a commit
that referenced
this pull request
Jan 2, 2025
* add completion for btrbk completions for btrbk https://github.com/digint/btrbk/ * change indent + spaces (cherry picked from commit 2ac1523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added completions for btrbk
TODOs: