Add completions for: termux-*
#10722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reformat code - remove redundant functions
faho
requested changes
Nov 27, 2024
| function __fish_termux_api__complete_group_ids | ||
| set -l command termux-notification-list | ||
| set ids ($command | jq --raw-output '.[].group') | ||
| set titles ($command | jq --raw-output '.[].title') |
Member
There was a problem hiding this comment.
jq is not guaranteed to be installed, so you would have to check if it is available first.
It's also pretty slow - we've sped up our json reading by using python instead (which would also need to be checked, use __fish_anypython)
And this $command is useless, please just call the command directly.
Member
|
Alright, I'm going to be closing these because there are unaddressed concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add completions for:
termux-*.Fixes issue #
Features
Progress
TODOs: