vi mode: support increment/decrement of numbers #10704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what it's worth, I had also gotten my own version implemented by now, just haven't gotten around to upstreaming it: master...d-e-s-o:fish-shell:topic/increment-decrement Haven't looked at the changes at hand to judge which one is nicer. |
ridiculousfish
requested changes
Sep 14, 2024
There was a problem hiding this comment.
Thank you for tackling this. Please add a test if possible to the bind.py tests, in the vi section
rename to __fish_inc_dec_number_under_cursor
added -- to handle negative numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use ctrl+x ctrl+a to increase/decrease a number
Fixes issue #8320
TODOs: