Skip to content

Conversation

@sgtm0113
Copy link
Contributor

@sgtm0113 sgtm0113 commented Sep 1, 2024

Description

Add fllowing input functions:

  • backward-delete-bigword
  • backward-delete-path-component
  • backward-delete-word
  • delete-bigword
  • delete-word

TODOs:

  • Add new items to enum ReadlineCmd
  • Add mapping about new functions to INPUT_FUNCTION_METADATA
  • Add descriptions about new functions to doc_src/cmds/bind.rst
  • I have not found tests relevant to input functions

(Something may be wrong because I'm not so good at writing both of Rust and English.)

@ridiculousfish
Copy link
Member

We have these bindings already - replace delete with kill. For example backward-kill-bigword

The only difference is how they interact with the kill ring - is that the intention of the PR?

@sgtm0113
Copy link
Contributor Author

The only difference is how they interact with the kill ring - is that the intention of the PR?

Yes, I wanted to not modify kill ring.

@zanchey
Copy link
Member

zanchey commented Jan 7, 2025

I don't think we're particularly keen to have this in, then - not sure what others think?

@zanchey zanchey added RFC and removed question labels Jan 7, 2025
@faho
Copy link
Member

faho commented Jan 9, 2025

Yeah, I'm inclined to close this.

@faho
Copy link
Member

faho commented Mar 16, 2025

Alright, it appears we don't want to take this, closing.

Sorry!

@faho faho closed this Mar 16, 2025
@zanchey zanchey added this to the will-not-implement milestone Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants