Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(firebase_database): refactored and added some query integration tests #6868

Merged
merged 2 commits into from
Aug 25, 2021
Merged

test(firebase_database): refactored and added some query integration tests #6868

merged 2 commits into from
Aug 25, 2021

Conversation

deepak786
Copy link
Contributor

@deepak786 deepak786 commented Aug 23, 2021 •
edited
Loading

Description

This PR refactors the integration tests by creating a separate class query_e2e.dart. Also added some new query tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Aug 23, 2021
@deepak786 deepak786 changed the title refactor(firebase_database): refactored and added some query tests refactor(firebase_database): refactored and added some query integration tests Aug 23, 2021
@deepak786 deepak786 mentioned this pull request Aug 23, 2021
Closed
russellwheatley
russellwheatley approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are running and passing:
Screenshot 2021-08-24 at 13 03 16

LGTM.

@russellwheatley russellwheatley changed the title refactor(firebase_database): refactored and added some query integration tests test(firebase_database): refactored and added some query integration tests Aug 24, 2021
@russellwheatley russellwheatley merged commit 81aba6a into firebase:master Aug 25, 2021
@deepak786 deepak786 deleted the firebase_database_integration_tests branch August 31, 2021 09:49
@firebase firebase locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@russellwheatley russellwheatley russellwheatley approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepak786 @russellwheatley