refactor(firebase_database): firebase_database_platform_interface #6668

deepak786 · 2021-07-21T10:22:53Z

Description

create separate firebase_database_platform_interface package
federate firebase_database plugin

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
All existing and new tests are passing.
I updated/added relevant documentation (doc comments with ///).
The analyzer (melos run analyze) does not report any problems on my PR.
I read and followed the [Flutter Style Guide].
I signed the [CLA].
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change.
No, this is not a breaking change.

google-cla · 2021-07-21T10:22:58Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

deepak786 · 2021-07-21T10:24:36Z

@googlebot I signed it!

deepak786

if we make this enum (EventType) public (which is not required for now) then need to update the event string in native sides also. Should I make this EventType enum public?

deepak786 · 2021-07-22T09:35:33Z

@Salakar I have submitted this pull request which will create a separate firebase_platform_database_reference and federate the firebase_database.
But as per the comment #1835 (comment), you also want to improve the integration tests.
Could you please guide or help to improve the integration tests?

…m_interface

deepak786 · 2021-08-25T14:57:08Z

check all_plugins / analyze (pull_request) is failing because I have used the path dependency of firebase_database_platform_interface to federate the firebase_database plugin.
firebase_database_platform_interface is not available on pub.dev yet.

…m_interface

# Conflicts: # packages/firebase_database/firebase_database/pubspec.yaml

lesnitsky

all comments are related to the code which was moved around, not authored by the @deepak786, so not sure if that should be of his concern. @Salakar thoughts?

...ase/firebase_database_platform_interface/lib/src/method_channel/method_channel_database.dart

...se_database_platform_interface/lib/src/method_channel/method_channel_database_reference.dart

...tabase/firebase_database_platform_interface/lib/src/method_channel/method_channel_query.dart

...firebase_database/firebase_database_platform_interface/lib/src/platform_interface/query.dart

google-cla · 2021-09-01T14:47:54Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-01T14:50:56Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-01T14:51:50Z

☹️ Sorry, but only Googlers may change the label cla: yes.

google-cla · 2021-09-02T12:46:55Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

lesnitsky · 2021-09-02T12:47:08Z

@deepak786 would you be willing to give your consent for co-authoring this? I've fixed my comments myself 😉

lesnitsky · 2021-09-02T12:47:32Z

@googlebot I consent.

deepak786 · 2021-09-02T12:52:39Z

@googlebot I consent.

deepak786 · 2021-09-02T12:53:42Z

@lesnitsky is that you asked?

lesnitsky · 2021-09-02T12:54:30Z

@deepak786 yes, thanks

created firebase_database_platform_interface

d1cf855

google-cla bot added the cla: no label Jul 21, 2021

google-cla bot added cla: yes and removed cla: no labels Jul 21, 2021

deepak786 mentioned this pull request Jul 21, 2021

[firebase_database] Add web support to plugin flutter/flutter#48542

Closed

deepak786 added 2 commits July 21, 2021 17:31

make the reference required

ebf8a73

migrate to use firebase_database_platform_interface

6ab8b32

deepak786 changed the title ~~created firebase_database_platform_interface~~ [firebase_database]: created firebase_database_platform_interface Jul 21, 2021

deepak786 changed the title ~~[firebase_database]: created firebase_database_platform_interface~~ [firebase_database] created firebase_database_platform_interface Jul 21, 2021

deepak786 added 4 commits July 21, 2021 21:04

make enum EventType private

9b99491

use query platfiorm getters

caada8c

added delegate property

b13e6f9

added channel getter

6eadc89

deepak786 commented Jul 21, 2021

View reviewed changes

deepak786 mentioned this pull request Jul 21, 2021

[firebase_database] Web support for realtime database #1835

Closed

13 tasks

deepak786 marked this pull request as draft July 21, 2021 18:51

deepak786 added 5 commits July 22, 2021 12:25

common MutableData and TransactionHandler

2ebbca4

pass transactionHandler

d4599b9

make EventType public

7285a4f

export EventType

6f3f8f6

updated string from _EventType to EventType

38a0255

deepak786 marked this pull request as ready for review July 22, 2021 07:29

deepak786 changed the title ~~[firebase_database] created firebase_database_platform_interface~~ [firebase_database] firebase_database_platform_interface Jul 22, 2021

deepak786 added 2 commits July 22, 2021 14:46

new list from pathComponents

33f098d

moved firebase_database_test to platform_interface

d495483

deepak786 added 2 commits July 27, 2021 18:06

Merge branch 'FirebaseExtended:master' into firebase_database_platfor…

c0229ce

…m_interface

Merge branch 'master' into firebase_database_platform_interface

748b05b

deepak786 and others added 2 commits August 25, 2021 17:05

Merge branch 'FirebaseExtended:master' into firebase_database_platfor…

8105ac2

…m_interface

reformat

323fb11

deepak786 and others added 3 commits August 25, 2021 20:36

Merge branch 'FirebaseExtended:master' into firebase_database_platfor…

52326ca

…m_interface

Merge branch 'master' into firebase_database_platform_interface

ec37cbf

# Conflicts: # packages/firebase_database/firebase_database/pubspec.yaml

updated firebase_core to 1.6.0

2efaefe

lesnitsky reviewed Sep 1, 2021

View reviewed changes

Merge branch 'master' into firebase_database_platform_interface

d737a6e

google-cla bot added cla: no and removed cla: yes labels Sep 1, 2021

fix(database): use platform_interface_version instead of path

dff9815

lesnitsky added cla: yes and removed cla: no labels Sep 1, 2021

google-cla bot removed the cla: yes label Sep 1, 2021

fix(database): fix review comments

16690a5

google-cla bot added the cla: no label Sep 2, 2021

google-cla bot added cla: yes and removed cla: no labels Sep 2, 2021

Salakar approved these changes Sep 2, 2021

View reviewed changes

Salakar merged commit ed4498a into firebase:master Sep 2, 2021

firebase locked and limited conversation to collaborators Oct 3, 2021

refactor(firebase_database): firebase_database_platform_interface #6668

refactor(firebase_database): firebase_database_platform_interface #6668

Uh oh!

Conversation

deepak786 commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Breaking Change

Uh oh!

google-cla bot commented Jul 21, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

deepak786 commented Jul 21, 2021

Uh oh!

deepak786 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepak786 commented Jul 22, 2021

Uh oh!

deepak786 commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesnitsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cla bot commented Sep 1, 2021

Uh oh!

google-cla bot commented Sep 1, 2021

Uh oh!

google-cla bot commented Sep 1, 2021

Uh oh!

google-cla bot commented Sep 2, 2021

Uh oh!

lesnitsky commented Sep 2, 2021

Uh oh!

lesnitsky commented Sep 2, 2021

Uh oh!

deepak786 commented Sep 2, 2021

Uh oh!

deepak786 commented Sep 2, 2021

Uh oh!

lesnitsky commented Sep 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

deepak786 commented Jul 21, 2021 •

edited

Loading

deepak786 left a comment •

edited

Loading

deepak786 commented Aug 25, 2021 •

edited

Loading