Skip to content

Conversation

@Salakar
Copy link
Member

@Salakar Salakar commented Apr 22, 2021

Description

As per #2852 (comment), this is a replacement PR for #2852.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Salakar Salakar requested review from Ehesp and kroikie as code owners April 22, 2021 14:33
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@github-actions
Copy link

github-actions bot commented Apr 22, 2021

Visit the preview URL for this PR (updated for commit 7aaf541):

https://flutter-firebase-docs--pr5887-salakar-move-databa-yebdwra8.web.app

(expires Thu, 29 Apr 2021 15:25:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All appears self-evidently correct

@Salakar Salakar merged commit 2ca4764 into master Apr 22, 2021
@Salakar Salakar deleted the @salakar/move-database branch April 22, 2021 15:57
@firebase firebase locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants