Enable --inspect-functions across multiple codebases #6854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6854 +/- ##
==========================================
- Coverage 54.26% 54.24% -0.02%
==========================================
Files 352 352
Lines 24519 24531 +12
Branches 5075 5079 +4
==========================================
+ Hits 13305 13307 +2
- Misses 9998 10009 +11
+ Partials 1216 1215 -1 ☔ View full report in Codecov by Sentry. |
joehan
approved these changes
Mar 11, 2024
src/emulator/functionsEmulator.ts
Outdated
| this.logger.logLabeled( | ||
| "SUCCESS", | ||
| "functions", | ||
| `Using debug port ${port} for functions codebase ${backend.codebase}`, |
There was a problem hiding this comment.
For ports other than 9299, maybe remind users that they will have to add the port to inspector manually in this message - ie:
Using debug port 9300 for functions codebase ${backend.codebase}. You may need to add manually add this port to your inspector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feature request in #6817.
When testing I was able to get this to work, but unfortunately Chrome doesn't scan all ports, so you need to manually add the address in Chrome:
Snippet from the console output in testing:
We start with port 9229 as it's default configured in Chrome. Additional ports will need to be added manually.