Skip to content

Release Firestore Emulator v1.19.2 #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harshyyy21 merged 2 commits into from
Mar 4, 2024
Merged

Release Firestore Emulator v1.19.2 #6832

harshyyy21 merged 2 commits into from
Mar 4, 2024

Conversation

@harshyyy21
Copy link
Contributor

@harshyyy21 harshyyy21 commented Mar 4, 2024

Description

This PR updates the Firestore Emulator to v1.19.2

Scenarios Tested

node lib/bin/firebase.js emulators:start --only firestore
(node:72801) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
⚠  Could not find config (firebase.json) so using defaults.
i  emulators: Starting emulators: firestore
⚠  firestore: Did not find a Cloud Firestore rules file specified in a firebase.json config file.
⚠  firestore: The emulator will default to allowing all reads and writes. Learn more about this option: https://firebase.google.com/docs/emulator-suite/install_and_configure#security_rules_configuration.
i  firestore: Firestore Emulator logging to firestore-debug.log
✔  firestore: Firestore Emulator UI websocket is running on 9150.
⚠  emulators: The Emulator UI is not starting, either because none of the running emulators have a UI component or the Emulator UI cannot determine the Project ID. Pass the --project flag to specify a project.

joehan
joehan approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@joehan
Copy link
Member

joehan commented Mar 4, 2024

Once this merges, could you take a pass thru the recent open issues and close/respond to any that are fixed by this? #6827 seems like it might be?

@harshyyy21 @joehan
Update CHANGELOG.md
7fa9d10 
Co-authored-by: joehan <[email protected]>
@harshyyy21
Copy link
Contributor Author

harshyyy21 commented Mar 4, 2024

Once this merges, could you take a pass thru the recent open issues and close/respond to any that are fixed by this? #6827 seems like it might be?

Yup, this linked issue will be fixed after this release. I can follow up

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.23%. Comparing base (730aeae) to head (7fa9d10).
⚠️ Report is 1171 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6832   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files         352      352           
  Lines       24524    24524           
  Branches     5073     5073           
=======================================
  Hits        13300    13300           
  Misses      10010    10010           
  Partials     1214     1214

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harshyyy21 harshyyy21 merged commit f740151 into master Mar 4, 2024
@aalej
Copy link
Contributor

aalej commented Mar 4, 2024

Just to note, tried reproducing #6808 and #6812 using this branch and issues still seem to be reproducible.

@joehan joehan mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joehan joehan joehan approved these changes

@christhompsongoogle christhompsongoogle christhompsongoogle approved these changes

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harshyyy21 @joehan @codecov-commenter @aalej @christhompsongoogle