Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Next.js version #6816

Merged
merged 6 commits into from
Feb 28, 2024
Merged

bump Next.js version #6816

merged 6 commits into from
Feb 28, 2024

Conversation

leoortizz
Copy link
Member

@leoortizz leoortizz commented Feb 26, 2024

Description

Bump Next.js version to 14 so we can use its new types. The new Next.js version required new versions of:

  • @types/node: used ^18.19.1
  • @types/react: used the latest
  • @types/react-dom: used the latest

The only manifest that has a new version is the PrerenderManifest, which is version 4 since Next.js v13.2.0. I initially kept v3 but it should not be needed as there are no breaking changes. The difference is that version 4 has more fields, which are visible in this change, but nothing was removed, so that should not break our integration.

Scenarios Tested

tests
deploy

Sample Commands

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.23%. Comparing base (1fb1382) to head (6ff5028).

Files Patch % Lines
src/frameworks/next/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6816   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files         352      352           
  Lines       24500    24500           
  Branches     5069     5069           
=======================================
  Hits        13287    13287           
  Misses      10000    10000           
  Partials     1213     1213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoortizz leoortizz enabled auto-merge (squash) February 28, 2024 18:21
@leoortizz leoortizz merged commit 06220c3 into master Feb 28, 2024
35 checks passed
@jamesdaniels jamesdaniels deleted the leoortizz_nextjs14 branch February 28, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants