Skip to content

Disables KeepAlive timeout when debugger is attached to the functions emulator #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taeold merged 3 commits into from
Jul 6, 2023
Merged

Disables KeepAlive timeout when debugger is attached to the functions emulator #6069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6a3034
disable keepalive timeout when debugger is attached
blidd-google Jun 30, 2023
dd08c71
add changelog entry
blidd-google Jun 30, 2023
092c593
Merge branch 'master' into bl-fix-debugger-node19
taeold Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disables KeepAlive timeout when debugger is attached to the functions emulator. (#6069)
13 changes: 11 additions & 2 deletions src/emulator/functionsRuntimeWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,12 @@ export class RuntimeWorker {
});
}

request(req: http.RequestOptions, resp: http.ServerResponse, body?: unknown): Promise<void> {
request(
req: http.RequestOptions,
resp: http.ServerResponse,
body?: unknown,
debug?: boolean
): Promise<void> {
if (this.triggerKey !== FREE_WORKER_KEY) {
this.logInfo(`Beginning execution of "${this.triggerKey}"`);
}
Expand Down Expand Up @@ -176,6 +181,10 @@ export class RuntimeWorker {
const piped = _resp.pipe(resp);
piped.on("finish", () => finishReq("finish"));
});
if (debug) {
proxy.setSocketKeepAlive(false);
proxy.setTimeout(0);
}
proxy.on("timeout", () => {
this.logger.log(
"ERROR",
Expand Down Expand Up @@ -367,7 +376,7 @@ export class RuntimeWorkerPool {
if (debug) {
await worker.sendDebugMsg(debug);
}
return worker.request(req, resp, body);
return worker.request(req, resp, body, !!debug);
}

getIdleWorker(triggerId: string | undefined): RuntimeWorker | undefined {
Expand Down