-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploying only functions removes all extensions. #7582
Comments
This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information. |
Hey @siarheidudko, sorry to hear you encountered this issue and thanks for reporting this. I’ll raise this to our engineering team and try to bring someone who can take a look into this. Apologies again for the issue this has caused. |
If you don't have your extension defined in the firebase.json file then you are asked to remove all the extensions - if enter "Y" the will be removed. |
It did not asked anything, because this operation would have blocked CI. In
addition, I've only been deploying functions, but not extensions. I have
always set up extensions directly in the UI interface.
Чт, 22 авг. 2024 г. в 22:47, Geoffrey Bourne ***@***.***>:
… If you don't have your extension defined in the firebase.json file then
you are asked to remove all the extensions - if enter "Y" the will be
removed.
—
Reply to this email directly, view it on GitHub
<#7582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIXASJQRYVV7XMCBB4V7AB3ZSYW27AVCNFSM6AAAAABM5UGPCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGQYTMOBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The "--force" prevented the ask. |
Previously, publishing only functions did not cause any actions with
extensions. If you do not consider this a issue, then the major version of
the application should have been upgraded. Because this is a breaking
backwards incompatible functionality.
Пт, 23 авг. 2024 г. в 00:14, Geoffrey Bourne ***@***.***>:
… It did not asked anything, because this operation would have blocked CI.
In addition, I've only been deploying functions, but not extensions. I have
always set up extensions directly in the UI interface. Чт, 22 авг. 2024 г.
в 22:47, Geoffrey Bourne *@*.
*>: … <#m_-7173298374939350900_> If you don't have your extension defined
in the firebase.json file then you are asked to remove all the extensions -
if enter "Y" the will be removed. — Reply to this email directly, view it
on GitHub <#7582 (comment)
<#7582 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIXASJQRYVV7XMCBB4V7AB3ZSYW27AVCNFSM6AAAAABM5UGPCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGQYTMOBYGM
<https://github.com/notifications/unsubscribe-auth/AIXASJQRYVV7XMCBB4V7AB3ZSYW27AVCNFSM6AAAAABM5UGPCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGQYTMOBYGM>
. You are receiving this because you were mentioned.Message ID: @.*>
The "--force" prevented the ask.
—
Reply to this email directly, view it on GitHub
<#7582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIXASJTX7RY2LDRSDCCBZWTZSZBBJAVCNFSM6AAAAABM5UGPCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGU2TCMRVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I've just faced this change also and trying to workaround it. My functions do not deploy anymore asking extensions to be added to the |
@yurist38 I downgraded the version to 13.15.2 to be able to deploy projects without affecting extensions. |
@siarheidudko good to know, thanks for sharing! I've decided to properly structure my project, actually didn't take me too long. So I've added the extensions to the json manifest already, it turned out they have support for setting up multiple projects (I used project suffix for the env files) |
This is a major problem for people (like me) who use UI interface to install extensions. Now I am asked each time whether to delete the extension functions. Entering Y by mistake once would end up in a nightmare. It used to work fine. Likely introduced by: #7575 |
I also have the same issue as mentioned by other commenters. We use firebase tools within our deployment workflows, and thus cannot interactively specify "N". Nor does it seem that the right answer is specifying I suppose I could do something similar to #7582 (comment) but this doesn't seem extensible to me; if I have a repository which is in charge of deploying a function or set of functions, it shouldn't need to know about all the extensions I've installed, and it would be difficult to create a system wherein when I create an extension I would remember to update my unrelated function deploying repositories/directories. Ideally the behavior could be returned to the status quo where my repository that only concerns itself with functions need not know about my extensions or their configuration. Thanks for your consideration. |
Hey everyone, apologies for the trouble here. We're rolling out a new way to declare extensions from within your functions codebases soon, and this change was meant to se the table for that. However, it ended up negatively users who installed extensions via the console and deploy only their functions via CLI. We're reverting this behavior change for now and will release a version today to get the changes out(dee2c89). Later, we'll revisit this feature and will roll it out again in a less disruptive way. |
@joehan I'm meet by the permission error on v13.19.0. Shouldn't this be fixed?
I use
Running with |
The firebaseextensions.instance.list permission is now required for any firebase deploy that includes functions. This is expected. It is because we have launched new features that allow you to define extension instances in your functions codebase and deploy them that way. See https://firebase.google.com/docs/extensions/install-extensions?interface=sdk) for details. This means that when we deploy functions we will always be checking if you have extension instances in your project that were defined using an autogenerated SDK in a deploying codebase. So we need to list the current extension instances in your project to determine if there is anything to potentially delete or configure or update. Consider enabling the (Note that this is different from the original bug.) |
Thank you for pointing that out, @ifielker. |
Hi @ifielker, thank you for pointing that out. The permission And weirdly adding the |
Hi @ifielker is your mentioned Because I can't seem to find the Edit (figured it out by myself): |
[REQUIRED] Environment info
**firebase-tools:**13.15.4
**Platform:**macOS
[REQUIRED] Test case
Use old
firebase.json
file withoutextensions
field or with:[REQUIRED] Steps to reproduce
Just run command:
firebase deploy --only functions --force
[REQUIRED] Expected behavior
Deploying only functions.
[REQUIRED] Actual behavior
Deploying only functions and removing all extensions.
The text was updated successfully, but these errors were encountered: