Hot fix: small quick update types for Server Side Rendering ( Angular Universal) #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiepxanh
requested review from
bojeil-google,
sphippen and
wti806
as code owners
bojeil-google
suggested changes
Jun 21, 2018
packages/auth-types/index.d.ts
Outdated
| @@ -279,12 +279,12 @@ export class FirebaseAuth { | |||
| languageCode: string | null; | |||
| settings: AuthSettings; | |||
| onAuthStateChanged( | |||
| nextOrObserver: Observer<any> | ((a: User | null) => any), | |||
| nextOrObserver: Observer<any,Error> | ((a: User | null) => any), | |||
There was a problem hiding this comment.
Add a space after the comma here and elsewhere.
|
@bojeil-google sir yes sir, sorry for my fault. I just updated it. Can you approve my pull request ? I'm very appreciate for that |
bojeil-google
approved these changes
Jun 21, 2018
|
I believe that the npm version available for now is out of date compare with github code. May you fix that, my PR will be unnecessary and I will close it. @bojeil-google |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm fixing types error when compiling AOT with angular universal
Discussion
fixing this issue Generic type 'Observer<V, E>' requires 2 type argument(s)
Testing
tested
API Changes
nope