-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata sync issue for cache listeners in multi-tab #8343
Fix metadata sync issue for cache listeners in multi-tab #8343
Conversation
🦋 Changeset detectedLatest commit: 6c3ef5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Could you please provide a PR description. A detail of the change, a link to the bug, etc? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things, thanks!
We should also get Mark Arndt's review on all things Firestore.
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
Issue: when creating a snapshot listener, it's
QueryTargetState
is simply set to "not-current" if it is listening to cache only. This is going to create out-of-sync metadata in persistence multi-tabs:scenario:
current
as well (fromCache=false)