Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markduckworth/sum avg 3 #7170

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Markduckworth/sum avg 3 #7170

merged 6 commits into from
Apr 25, 2023

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Mar 29, 2023

Test fixes and back-porting improvements from the Android+Java implementations. This also modifies the handling of user provided aliases, so that user provided aliases will not be sent to the server.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

🦋 Changeset detected

Latest commit: 51e4059

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (f5aec7b)Merge (6773185)Diff
    browser285 kB285 kB-190 B (-0.1%)
    esm5354 kB354 kB-174 B (-0.0%)
    main567 kB566 kB-180 B (-0.0%)
    module285 kB285 kB-190 B (-0.1%)
    react-native285 kB285 kB-190 B (-0.1%)
  • @firebase/firestore-lite

    TypeBase (f5aec7b)Merge (6773185)Diff
    browser87.7 kB87.5 kB-190 B (-0.2%)
    esm5106 kB105 kB-174 B (-0.2%)
    main149 kB149 kB-180 B (-0.1%)
    module87.7 kB87.5 kB-190 B (-0.2%)
    react-native87.9 kB87.7 kB-190 B (-0.2%)
  • bundle

    TypeBase (f5aec7b)Merge (6773185)Diff
    firestore (Query Cursors)236 kB236 kB+63 B (+0.0%)
    firestore (Query)234 kB234 kB+63 B (+0.0%)
    firestore (Read data once)221 kB221 kB+63 B (+0.0%)
    firestore (Realtime updates)223 kB223 kB+63 B (+0.0%)
    firestore (Transaction)201 kB201 kB+63 B (+0.0%)
    firestore-lite (Query Cursors)81.6 kB81.7 kB+63 B (+0.1%)
    firestore-lite (Query)77.7 kB77.8 kB+63 B (+0.1%)
    firestore-lite (Read data once)59.9 kB60.0 kB+63 B (+0.1%)
    firestore-lite (Transaction)84.7 kB84.7 kB+63 B (+0.1%)
  • firebase

    TypeBase (f5aec7b)Merge (6773185)Diff
    firebase-compat.js771 kB771 kB+63 B (+0.0%)
    firebase-firestore-compat.js338 kB338 kB+63 B (+0.0%)
    firebase-firestore-lite.js94.4 kB94.2 kB-190 B (-0.2%)
    firebase-firestore.js344 kB344 kB-190 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/T05NvsCqbY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023

Size Analysis Report 1

This report is too large (655,426 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VzO1CuRdOv.html

@MarkDuckworth MarkDuckworth requested review from a team as code owners April 25, 2023 15:56
@MarkDuckworth MarkDuckworth merged commit 510c9b5 into master Apr 25, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/sum-avg-3 branch April 25, 2023 16:54
@google-oss-bot google-oss-bot mentioned this pull request Apr 25, 2023
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants