Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new token method to App Check #7169

Merged
merged 11 commits into from
Apr 18, 2023
Merged

Add new token method to App Check #7169

merged 11 commits into from
Apr 18, 2023

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 29, 2023

No description provided.

@sam-gc sam-gc requested a review from hsubox76 as a code owner March 29, 2023 22:29
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 38efaa6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app-check Minor
firebase Minor
@firebase/app-check-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (a059af0)Merge (aacbd96)Diff
    browser25.7 kB26.2 kB+516 B (+2.0%)
    esm530.7 kB31.4 kB+718 B (+2.3%)
    main31.8 kB32.6 kB+827 B (+2.6%)
    module25.7 kB26.2 kB+516 B (+2.0%)

  • @firebase/firestore

    TypeBase (a059af0)Merge (aacbd96)Diff
    browser278 kB281 kB+3.02 kB (+1.1%)
    esm5346 kB350 kB+3.81 kB (+1.1%)
    main554 kB560 kB+5.56 kB (+1.0%)
    module278 kB281 kB+3.02 kB (+1.1%)
    react-native279 kB282 kB+3.02 kB (+1.1%)

  • bundle

    TypeBase (a059af0)Merge (aacbd96)Diff
    firestore (Persistence)284 kB284 kB+5 B (+0.0%)

  • firebase

    TypeBase (a059af0)Merge (aacbd96)Diff
    firebase-app-check.js21.8 kB22.1 kB+264 B (+1.2%)
    firebase-firestore.js327 kB330 kB+3.02 kB (+0.9%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tyJE45tTB9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (720,489 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/R5DybJWCXg.html

hsubox76
hsubox76 reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question about combining the internal implementation with getToken() in comments. Also don't forget to (1) add a changeset, (2) run the docgen, and (3) get a review from the tech writer (should be @kevinthecheung ).

packages/app-check/src/internal-api.ts Outdated Show resolved Hide resolved
packages/app-check/src/internal-api.ts Outdated Show resolved Hide resolved
packages/app-check/src/internal-api.ts Outdated Show resolved Hide resolved
@sam-gc
Copy link
Contributor Author

sam-gc commented Apr 6, 2023 •
edited
Loading

Public docs are still up in the air a bit.

rosalyntan
rosalyntan reviewed Apr 8, 2023
View reviewed changes
common/api-review/app-check.api.md Outdated Show resolved Hide resolved
packages/app-check/src/api.test.ts Outdated Show resolved Hide resolved
packages/app-check/src/internal-api.ts Outdated Show resolved Hide resolved
hsubox76
hsubox76 reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to generate new docs (yarn docgen devsite) and check them in and get them reviewed by @kevinthecheung.

@sam-gc
Copy link
Contributor Author

sam-gc commented Apr 12, 2023

I added the docgen content

hsubox76
hsubox76 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just some minor nits.

packages/app-check/src/internal-api.test.ts Outdated Show resolved Hide resolved
packages/app-check/src/internal-api.test.ts Outdated Show resolved Hide resolved
egilmorez
egilmorez approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG based on Kevin's review, thanks!

@sam-gc sam-gc merged commit 195e82e into master Apr 18, 2023
@sam-gc sam-gc deleted the sam-gc/fac branch April 18, 2023 20:00
@google-oss-bot google-oss-bot mentioned this pull request Apr 25, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@rosalyntan rosalyntan rosalyntan approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez egilmorez approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@markarndt markarndt Awaiting requested review from markarndt

Assignees

@hsubox76 hsubox76

@rosalyntan rosalyntan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-gc @google-oss-bot @egilmorez @hsubox76 @rosalyntan @kevinthecheung