Add implementation of getGoogleAnalyticsClientId #7158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9357f51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (726,787 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
dwyfrequency
requested review from
egilmorez,
markarndt and
hsubox76
as code owners
|
Still need to write the tests for the |
hsubox76
reviewed
Mar 27, 2023
DellaBitta
reviewed
Apr 12, 2023
hsubox76
reviewed
Apr 12, 2023
dwyfrequency
requested review from
zwu52,
maneesht,
tonyjhuang and
jsdt
as code owners
dwyfrequency
force-pushed
the
jd-getclientid-analytics-v2
branch
from
2c0c2e2
to
7149472
Compare
hsubox76
removed request for
erikeldridge,
jposuna,
yoyomyo,
renkelvin,
tonyjhuang,
avolkovi,
sam-gc,
jsdt,
maneesht,
lisajian,
zwu52 and
prameshj
hsubox76
approved these changes
Apr 14, 2023
markarndt
approved these changes
Apr 14, 2023
dwyfrequency
force-pushed
the
jd-getclientid-analytics-v2
branch
from
dce697c
to
93ed844
Compare
hsubox76
approved these changes
Apr 18, 2023
dwyfrequency
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we were presented with use cases where users wanted to log purchase and other events from their backends using Google Analytics 4 Measurement Protocol and to have those events be connected to actions taken on the client within their Firebase web app. In the event sending documentation, it dictates that app_instance_id is required for Firebase but this is only focused on Firebase for mobile. Because the JS SDK analytics package is a wrapper around gtag, we must use gtag's client_id instead of app_instance_id for Measurement Protocol. To simplify the retrieval process from our analytics packages, we will add a getGoogleAnalyticsClientId() method. getGoogleAnalyticsClientId() will retrieve an unique identifier for a web client.