OR Query public API #7053
OR Query public API #7053
Conversation
…kduckworth/public-or-queries
…osite indexes to only run against the emulator.
MarkDuckworth
requested review from
dwyfrequency and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: 8e32951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (722325a) and merge commit (af3ce1b).Test Logs |
Size Analysis Report 1This report is too large (716,213 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
|
@egilmorez please take a look at these documentation changes for the public API for the upcoming OR query feature. |
…/firebase-js-sdk into markduckworth/public-or-queries
…kduckworth/public-or-queries
| @@ -0,0 +1,35 @@ | |||
| Project: /docs/reference/js/_project.yaml | |||
There was a problem hiding this comment.
Did I forget to press a button earlier today . . . ??
Anyway, my question was: why are these output files included in the PR? Generally we do those in a follow-on CL. Thanks!
There was a problem hiding this comment.
@egilmorez, this is a required CI step now. PR's that will result in a public documentation change will include updates to the docs-devsite/ folder.
There was a problem hiding this comment.
@egilmorez ... wrt to the feature, this content looks fine. Do you want resolution to this discussion before I give the single approval that will unblock?
There was a problem hiding this comment.
Nope, go ahead Mark, thanks! I'm curious see if a doc CL crosses my "desk."
.changeset/sweet-rats-compete.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@firebase/firestore": feat | |||
There was a problem hiding this comment.
Update to
'@firebase/firestore': minor
'firebase': minor
There was a problem hiding this comment.
Modified. Thank you for the review.
* Relaxing in restrictions. * Additional testing. * Relaxing query restrictions. * Code cleanup. * Removing compat tests that perform validation on the old query restrictions. * Making OR Queries public. * Enabling tests for or queries and configuring tests that require composite indexes to only run against the emulator. * Create sweet-rats-compete.md * Fixing documentation errors revealed by the doc change check. * Removing and renaming tests based on PR feedback. * Correcting the change type in the changeset file. * Disable tests that have multiple ins or array-contains-any per query.
* Relaxing in restrictions. * Additional testing. * Relaxing query restrictions. * Code cleanup. * Removing compat tests that perform validation on the old query restrictions. * Making OR Queries public. * Enabling tests for or queries and configuring tests that require composite indexes to only run against the emulator. * Create sweet-rats-compete.md * Fixing documentation errors revealed by the doc change check. * Removing and renaming tests based on PR feedback. * Correcting the change type in the changeset file. * Disable tests that have multiple ins or array-contains-any per query.
Adding the OR Query public API