New way to config Firestore SDK Cache. #7015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e6b8250 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wu-hui
force-pushed
the
wuandy/NewCacheConfig
branch
from
2555b58
to
da41013
Compare
wu-hui
force-pushed
the
wuandy/NewCacheConfig
branch
from
da41013
to
4ed6691
Compare
MarkDuckworth
approved these changes
Feb 8, 2023
wu-hui
force-pushed
the
wuandy/NewCacheConfig
branch
from
c628e6a
to
7d0b186
Compare
wu-hui
force-pushed
the
wuandy/NewCacheConfig
branch
3 times, most recently
from
6c83a97
to
6535efa
Compare
Size Report 1Affected Products
Test Logs |
wu-hui
force-pushed
the
wuandy/NewCacheConfig
branch
from
6535efa
to
d651d88
Compare
Size Analysis Report 1This report is too large (790,994 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
markarndt
approved these changes
Mar 3, 2023
hsubox76
reviewed
Mar 6, 2023
There was a problem hiding this comment.
Can you run yarn docgen devsite to generate new files in docs-devsite? There's a message in https://github.com/firebase/firebase-js-sdk/actions/runs/4345091205/jobs/7589318276 but it's not very easy to find, sorry.
| } | ||
|
|
||
| /** | ||
| * @deprecated This function will be removed in a future major release. Instead, set |
There was a problem hiding this comment.
I'm not sure but I think this tag needs to go at the bottom of the comment block. You can double check when you run yarn docs devsite.
There was a problem hiding this comment.
Done in the latest commit.
hsubox76
reviewed
Mar 8, 2023
hsubox76
approved these changes
Mar 8, 2023
wu-hui
force-pushed
the
wuandy/NewCacheConfig
branch
from
56b199d
to
e6b8250
Compare
renkelvin
pushed a commit
that referenced
this pull request
Mar 21, 2023
* New way to config Firestore SDK Cache. * fixups * Fix some test failures * Fixing dts file * Add public comments * API report * Create brown-beers-tease.md * warning messages and more tests * Addressing comments * Update API reports * Fix provider test failure for node w/o indexeddb * Fix node memory test * rename cache to localCache * Update API reports * Tech writer review * yarn docgen * auth change * Update API reports * docgen devsite * Fix changeset * Another auth change * more devsite fix * Update API reports * Rename indexeddb to persistent --------- Co-authored-by: wu-hui <[email protected]>
dwyfrequency
pushed a commit
that referenced
this pull request
Mar 23, 2023
* New way to config Firestore SDK Cache. * fixups * Fix some test failures * Fixing dts file * Add public comments * API report * Create brown-beers-tease.md * warning messages and more tests * Addressing comments * Update API reports * Fix provider test failure for node w/o indexeddb * Fix node memory test * rename cache to localCache * Update API reports * Tech writer review * yarn docgen * auth change * Update API reports * docgen devsite * Fix changeset * Another auth change * more devsite fix * Update API reports * Rename indexeddb to persistent --------- Co-authored-by: wu-hui <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual test link (private repo): https://github.com/FirebasePrivate/firestore-team/pull/50