Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory usage by applying query check sooner #6989

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Reduce memory usage by applying query check sooner #6989

merged 3 commits into from
Jan 31, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jan 30, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b7e4349

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (825e648)Merge (bcd3d2e)Diff
    browser273 kB273 kB+107 B (+0.0%)
    esm5339 kB339 kB+107 B (+0.0%)
    main545 kB546 kB+240 B (+0.0%)
    module273 kB273 kB+107 B (+0.0%)
    react-native273 kB273 kB+107 B (+0.0%)

  • bundle

    TypeBase (825e648)Merge (bcd3d2e)Diff
    firestore (Persistence)281 kB281 kB+107 B (+0.0%)
    firestore (Query Cursors)220 kB220 kB+43 B (+0.0%)
    firestore (Query)217 kB218 kB+43 B (+0.0%)
    firestore (Read data once)205 kB205 kB+43 B (+0.0%)
    firestore (Realtime updates)207 kB207 kB+43 B (+0.0%)
    firestore (Transaction)188 kB188 kB+43 B (+0.0%)
    firestore (Write data)188 kB188 kB+43 B (+0.0%)

  • firebase

    TypeBase (825e648)Merge (bcd3d2e)Diff
    firebase-compat.js747 kB747 kB+109 B (+0.0%)
    firebase-firestore-compat.js321 kB321 kB+109 B (+0.0%)
    firebase-firestore.js321 kB321 kB+107 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZETToQJauJ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • addDoc

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size118 kB118 kB+43 B (+0.0%)
      size-with-ext-deps178 kB178 kB+43 B (+0.0%)

    • deleteDoc

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size109 kB109 kB+43 B (+0.0%)
      size-with-ext-deps169 kB169 kB+43 B (+0.0%)

    • disableNetwork

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size97.6 kB97.6 kB+43 B (+0.0%)
      size-with-ext-deps157 kB157 kB+43 B (+0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size179 kB179 kB+107 B (+0.1%)
      size-with-ext-deps240 kB240 kB+107 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size211 kB211 kB+107 B (+0.1%)
      size-with-ext-deps272 kB272 kB+107 B (+0.0%)

    • enableNetwork

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size97.6 kB97.6 kB+43 B (+0.0%)
      size-with-ext-deps157 kB157 kB+43 B (+0.0%)

    • executeWrite

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size108 kB108 kB+43 B (+0.0%)
      size-with-ext-deps168 kB168 kB+43 B (+0.0%)

    • getCountFromServer

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size104 kB104 kB+43 B (+0.0%)
      size-with-ext-deps164 kB164 kB+43 B (+0.0%)

    • getDoc

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size135 kB135 kB+43 B (+0.0%)
      size-with-ext-deps194 kB194 kB+43 B (+0.0%)

    • getDocFromCache

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size90.7 kB90.7 kB+43 B (+0.0%)
      size-with-ext-deps150 kB150 kB+43 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size135 kB135 kB+43 B (+0.0%)
      size-with-ext-deps194 kB194 kB+43 B (+0.0%)

    • getDocs

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size136 kB137 kB+43 B (+0.0%)
      size-with-ext-deps196 kB196 kB+43 B (+0.0%)

    • getDocsFromCache

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size98.4 kB98.4 kB+43 B (+0.0%)
      size-with-ext-deps157 kB157 kB+43 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size136 kB136 kB+43 B (+0.0%)
      size-with-ext-deps196 kB196 kB+43 B (+0.0%)

    • loadBundle

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size107 kB107 kB+43 B (+0.0%)
      size-with-ext-deps166 kB166 kB+43 B (+0.0%)

    • namedQuery

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size84.2 kB84.2 kB+43 B (+0.1%)
      size-with-ext-deps143 kB143 kB+43 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size137 kB137 kB+43 B (+0.0%)
      size-with-ext-deps197 kB197 kB+43 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size127 kB127 kB+43 B (+0.0%)
      size-with-ext-deps186 kB186 kB+43 B (+0.0%)

    • runTransaction

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size118 kB118 kB+43 B (+0.0%)
      size-with-ext-deps178 kB178 kB+43 B (+0.0%)

    • setDoc

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size117 kB117 kB+43 B (+0.0%)
      size-with-ext-deps177 kB177 kB+43 B (+0.0%)

    • setIndexConfiguration

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size86.8 kB86.8 kB+43 B (+0.0%)
      size-with-ext-deps146 kB146 kB+43 B (+0.0%)

    • updateDoc

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size118 kB118 kB+43 B (+0.0%)
      size-with-ext-deps177 kB177 kB+43 B (+0.0%)

    • waitForPendingWrites

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size98.0 kB98.1 kB+43 B (+0.0%)
      size-with-ext-deps157 kB157 kB+43 B (+0.0%)

    • writeBatch

      Size

      TypeBase (825e648)Merge (bcd3d2e)Diff
      size120 kB120 kB+43 B (+0.0%)
      size-with-ext-deps179 kB179 kB+43 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dABU5nNrOS.html

@wu-hui wu-hui requested a review from ehsannas January 30, 2023 18:26
@wu-hui wu-hui merged commit 27b5e7d into master Jan 31, 2023
@wu-hui wu-hui deleted the wuandy/ApplyQueryInRemoteCache branch January 31, 2023 17:48
@google-oss-bot google-oss-bot mentioned this pull request Jan 31, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @ehsannas