Implemented exponential backoff with query #6653

maneesht · 2022-10-04T01:31:30Z

When upload requests respond with a 503, there is a situation where the bytes were uploaded, yet finalize did not occur. This can result in an incorrect offset being sent to the server. We should make a request that checks the status of the upload, and updating our offset based on that.

This PR implements that, along with a backoff feature, exponentially increasing the time between different requests being issued.

changeset-bot · 2022-10-04T01:31:33Z

🦋 Changeset detected

Latest commit: 05fa51b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/storage	Patch
firebase	Patch
@firebase/storage-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-10-04T01:52:05Z

Size Report ¹

Affected Products

@firebase/storage
Type Base (34ad43c) Merge (d22a93e) Diff
browser 54.7 kB 55.6 kB +891 B (+1.6%)
esm5 60.7 kB 61.8 kB +1.12 kB (+1.8%)
main 57.6 kB 58.4 kB +891 B (+1.5%)
module 54.7 kB 55.6 kB +891 B (+1.6%)

`bundle`

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
storage (getBytes)	39.9 kB	40.0 kB	+132 B (+0.3%)
storage (getDownloadURL)	42.0 kB	42.1 kB	+132 B (+0.3%)
storage (getMetadata)	41.4 kB	41.5 kB	+132 B (+0.3%)
storage (list + listAll)	40.8 kB	41.0 kB	+132 B (+0.3%)
storage (updateMetadata)	41.7 kB	41.8 kB	+132 B (+0.3%)
storage (uploadBytes)	46.2 kB	46.4 kB	+132 B (+0.3%)
storage (uploadBytesResumable)	55.6 kB	56.2 kB	+563 B (+1.0%)
storage (uploadString)	46.4 kB	46.6 kB	+132 B (+0.3%)

firebase
Type Base (34ad43c) Merge (d22a93e) Diff
firebase-compat.js 739 kB 740 kB +559 B (+0.1%)
firebase-storage-compat.js 38.2 kB 38.8 kB +560 B (+1.5%)
firebase-storage.js 37.8 kB 38.4 kB +565 B (+1.5%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/rDQaTwhz97.html

google-oss-bot · 2022-10-04T02:17:07Z

Size Analysis Report ¹

Affected Products

`@firebase/storage`

`StringFormat`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.0 kB	10.1 kB	+107 B (+1.1%)
size-with-ext-deps	27.0 kB	27.1 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

24 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`_FbsBlob`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	13.9 kB	14.0 kB	+109 B (+0.8%)
size-with-ext-deps	30.9 kB	31.0 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

39 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
getBlob$1
getBlobBuilder
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isString
lastComponent
makeQueryString
makeRequest
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
sliceBlob
start
stop
unknown
utf8Bytes_
validateNumber

40 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
getBlob$1
getBlobBuilder
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isRetryStatusCode
isString
lastComponent
makeQueryString
makeRequest
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
sliceBlob
start
stop
unknown
utf8Bytes_
validateNumber

+ isRetryStatusCode

`_Location`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	9.96 kB	10.1 kB	+107 B (+1.1%)
size-with-ext-deps	26.9 kB	27.0 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

24 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`_TaskEvent`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.0 kB	10.1 kB	+107 B (+1.1%)
size-with-ext-deps	26.9 kB	27.0 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

24 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`_TaskState`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.1 kB	10.2 kB	+107 B (+1.1%)
size-with-ext-deps	27.0 kB	27.1 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

24 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`_UploadTask`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	28.9 kB	29.5 kB	+570 B (+2.0%)
size-with-ext-deps	45.9 kB	46.5 kB	+563 B (+1.2%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

73 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
utf8Bytes_
validateNumber
xformPath

74 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
utf8Bytes_
validateNumber
xformPath

+ isRetryStatusCode

variables

12 dependencies

CONFIG_STORAGE_BUCKET_KEY
DEFAULT_HOST
DEFAULT_MAX_OPERATION_RETRY_TIME
DEFAULT_MAX_UPLOAD_RETRY_TIME
ErrorCode
RESUMABLE_UPLOAD_CHUNK_SIZE
STORAGE_TYPE
StringFormat
TaskState
mappings_
name
version

13 dependencies

CONFIG_STORAGE_BUCKET_KEY
DEFAULT_HOST
DEFAULT_MAX_OPERATION_RETRY_TIME
DEFAULT_MAX_UPLOAD_RETRY_TIME
DEFAULT_MIN_SLEEP_TIME_MILLIS
ErrorCode
RESUMABLE_UPLOAD_CHUNK_SIZE
STORAGE_TYPE
StringFormat
TaskState
mappings_
name
version

+ DEFAULT_MIN_SLEEP_TIME_MILLIS

`_dataFromString`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	12.2 kB	12.3 kB	+109 B (+0.9%)
size-with-ext-deps	29.1 kB	29.2 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

33 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
utf8Bytes_
validateNumber

34 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
utf8Bytes_
validateNumber

+ isRetryStatusCode

`_getChild`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.2 kB	10.3 kB	+107 B (+1.0%)
size-with-ext-deps	27.1 kB	27.2 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

27 dependencies

_getChild
_getChild$1
addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
child
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

28 dependencies

_getChild
_getChild$1
addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
child
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`_invalidArgument`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	9.96 kB	10.1 kB	+107 B (+1.1%)
size-with-ext-deps	26.9 kB	27.0 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

24 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`_invalidRootOperation`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	9.97 kB	10.1 kB	+107 B (+1.1%)
size-with-ext-deps	26.9 kB	27.0 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

24 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`connectStorageEmulator`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.2 kB	10.3 kB	+107 B (+1.0%)
size-with-ext-deps	27.7 kB	27.8 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

26 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
connectStorageEmulator
connectStorageEmulator$1
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

27 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
connectStorageEmulator
connectStorageEmulator$1
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`deleteObject`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	13.3 kB	13.4 kB	+133 B (+1.0%)
size-with-ext-deps	30.2 kB	30.4 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

37 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
deleteObject
deleteObject$1
deleteObject$2
extractBucket
factory
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
makeUrl
newTextConnection
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

38 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
deleteObject
deleteObject$1
deleteObject$2
extractBucket
factory
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
makeUrl
newTextConnection
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

+ isRetryStatusCode

`getBlob`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	13.4 kB	13.5 kB	+133 B (+1.0%)
size-with-ext-deps	30.3 kB	30.5 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

37 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
getBlob
getBlobInternal
getBytes$1
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
makeUrl
newBlobConnection
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

38 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
getBlob
getBlobInternal
getBytes$1
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
makeUrl
newBlobConnection
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

+ isRetryStatusCode

`getBytes`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	13.4 kB	13.5 kB	+133 B (+1.0%)
size-with-ext-deps	30.4 kB	30.5 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

37 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
getBytes
getBytes$1
getBytesInternal
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
makeUrl
newBytesConnection
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

38 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
getBytes
getBytes$1
getBytesInternal
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
makeUrl
newBytesConnection
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

+ isRetryStatusCode

`getDownloadURL`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	15.4 kB	15.5 kB	+132 B (+0.9%)
size-with-ext-deps	32.4 kB	32.6 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

50 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
canceled
downloadUrlFromResourceString
downloadUrlHandler
extractBucket
factory
fromResource
fromResourceString
getDownloadURL
getDownloadURL$1
getDownloadUrl
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
newTextConnection
noDownloadURL
noXform_
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber
xformPath

51 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
canceled
downloadUrlFromResourceString
downloadUrlHandler
extractBucket
factory
fromResource
fromResourceString
getDownloadURL
getDownloadURL$1
getDownloadUrl
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
newTextConnection
noDownloadURL
noXform_
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber
xformPath

+ isRetryStatusCode

`getMetadata`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	14.9 kB	15.0 kB	+132 B (+0.9%)
size-with-ext-deps	31.9 kB	32.0 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

48 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromResource
fromResourceString
getMappings
getMetadata
getMetadata$1
getMetadata$2
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataHandler
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber
xformPath

49 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromResource
fromResourceString
getMappings
getMetadata
getMetadata$1
getMetadata$2
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataHandler
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber
xformPath

+ isRetryStatusCode

`getStorage`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.4 kB	10.5 kB	+107 B (+1.0%)
size-with-ext-deps	35.5 kB	35.6 kB	+109 B (+0.3%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

27 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
connectStorageEmulator
connectStorageEmulator$1
extractBucket
factory
getStorage
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

28 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
connectStorageEmulator
connectStorageEmulator$1
extractBucket
factory
getStorage
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`getStream`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.0 kB	10.1 kB	+107 B (+1.1%)
size-with-ext-deps	27.0 kB	27.1 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

25 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
getStream
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

26 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
getStream
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`list`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	14.0 kB	14.1 kB	+132 B (+0.9%)
size-with-ext-deps	31.0 kB	31.1 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

41 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromBackendResponse
fromResponseString
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
jsonObjectOrNull
lastComponent
list
list$1
list$2
listHandler
makeQueryString
makeRequest
makeUrl
newTextConnection
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

42 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromBackendResponse
fromResponseString
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isRetryStatusCode
jsonObjectOrNull
lastComponent
list
list$1
list$2
listHandler
makeQueryString
makeRequest
makeUrl
newTextConnection
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

+ isRetryStatusCode

`listAll`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	14.2 kB	14.4 kB	+132 B (+0.9%)
size-with-ext-deps	31.2 kB	31.4 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

43 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromBackendResponse
fromResponseString
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
jsonObjectOrNull
lastComponent
list$1
list$2
listAll
listAll$1
listAllHelper
listHandler
makeQueryString
makeRequest
makeUrl
newTextConnection
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

44 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromBackendResponse
fromResponseString
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isRetryStatusCode
jsonObjectOrNull
lastComponent
list$1
list$2
listAll
listAll$1
listAllHelper
listHandler
makeQueryString
makeRequest
makeUrl
newTextConnection
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
unauthenticated
unauthorized
unauthorizedApp
unknown
validateNumber

+ isRetryStatusCode

`ref`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	10.8 kB	10.9 kB	+107 B (+1.0%)
size-with-ext-deps	27.8 kB	27.9 kB	+109 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

32 dependencies

_getChild$1
addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
child
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isUrl
lastComponent
makeQueryString
makeRequest
noDefaultBucket
parent
prependCode
ref
ref$1
refFromPath
refFromURL
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

33 dependencies

_getChild$1
addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
canceled
child
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
isUrl
lastComponent
makeQueryString
makeRequest
noDefaultBucket
parent
prependCode
ref
ref$1
refFromPath
refFromURL
registerStorage
retryLimitExceeded
start
stop
unknown
validateNumber

+ isRetryStatusCode

`updateMetadata`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	15.1 kB	15.3 kB	+132 B (+0.9%)
size-with-ext-deps	32.1 kB	32.3 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

49 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromResource
fromResourceString
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataHandler
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
updateMetadata
updateMetadata$1
updateMetadata$2
validateNumber
xformPath

50 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
canceled
extractBucket
factory
fromResource
fromResourceString
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidRootOperation
invalidUrl
isJustDef
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataHandler
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
updateMetadata
updateMetadata$1
updateMetadata$2
validateNumber
xformPath

+ isRetryStatusCode

`uploadBytes`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	19.7 kB	19.8 kB	+132 B (+0.7%)
size-with-ext-deps	36.7 kB	36.8 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

64 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes
uploadBytes$1
utf8Bytes_
validateNumber
xformPath

65 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes
uploadBytes$1
utf8Bytes_
validateNumber
xformPath

+ isRetryStatusCode

`uploadBytesResumable`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	29.1 kB	29.7 kB	+561 B (+1.9%)
size-with-ext-deps	46.1 kB	46.7 kB	+563 B (+1.2%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

75 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytesResumable
uploadBytesResumable$1
utf8Bytes_
validateNumber
xformPath

76 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytesResumable
uploadBytesResumable$1
utf8Bytes_
validateNumber
xformPath

+ isRetryStatusCode

variables

12 dependencies

CONFIG_STORAGE_BUCKET_KEY
DEFAULT_HOST
DEFAULT_MAX_OPERATION_RETRY_TIME
DEFAULT_MAX_UPLOAD_RETRY_TIME
ErrorCode
RESUMABLE_UPLOAD_CHUNK_SIZE
STORAGE_TYPE
StringFormat
TaskState
mappings_
name
version

13 dependencies

CONFIG_STORAGE_BUCKET_KEY
DEFAULT_HOST
DEFAULT_MAX_OPERATION_RETRY_TIME
DEFAULT_MAX_UPLOAD_RETRY_TIME
DEFAULT_MIN_SLEEP_TIME_MILLIS
ErrorCode
RESUMABLE_UPLOAD_CHUNK_SIZE
STORAGE_TYPE
StringFormat
TaskState
mappings_
name
version

+ DEFAULT_MIN_SLEEP_TIME_MILLIS

`uploadString`

Size

Type	Base (`34ad43c`)	Merge (`d22a93e`)	Diff
size	19.9 kB	20.0 kB	+133 B (+0.7%)
size-with-ext-deps	36.9 kB	37.0 kB	+132 B (+0.4%)

Dependency

Type Base (34ad43c) Merge (d22a93e) Diff

functions

65 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes$1
uploadString
uploadString$1
utf8Bytes_
validateNumber
xformPath

66 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes$1
uploadString
uploadString$1
utf8Bytes_
validateNumber
xformPath

+ isRetryStatusCode

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/7ricbtYyqI.html

…rebase/firebase-js-sdk into mtewani/exponential-backoff-2

packages/storage/src/implementation/error.ts

packages/storage/src/implementation/request.ts

packages/storage/src/implementation/utils.ts

packages/storage/src/implementation/requests.ts

packages/storage/src/task.ts

…rebase/firebase-js-sdk into mtewani/exponential-backoff-2

tonyjhuang

LGTM except one (optional) comment

packages/storage/src/implementation/constants.ts

…rebase/firebase-js-sdk into mtewani/exponential-backoff-2

Yuangwang · 2022-10-06T15:38:39Z

Thanks for the changes!

packages/storage/src/implementation/backoff.ts

egilmorez

LG based on Mark's review, thanks!

maneesht requested a review from tonyjhuang as a code owner October 4, 2022 01:31

maneesht requested a review from egilmorez as a code owner October 4, 2022 01:32

Implemented exponential backoff with query

bf8d206

maneesht force-pushed the mtewani/exponential-backoff-2 branch from 805ae65 to bf8d206 Compare October 4, 2022 01:44

Update API reports

d03295b

github-actions bot requested review from dwyfrequency and hsubox76 as code owners October 4, 2022 01:51

github-actions bot added the doc-changes PRs that affect docs label Oct 4, 2022

github-actions bot assigned egilmorez Oct 4, 2022

maneesht and others added 3 commits October 4, 2022 09:59

Added comment on how backoff works

571fafb

Merge branch 'mtewani/exponential-backoff-2' of https://github.com/fi…

7939673

…rebase/firebase-js-sdk into mtewani/exponential-backoff-2

Create large-lamps-reflect.md

f48717f

tonyjhuang requested changes Oct 5, 2022

View reviewed changes

maneesht and others added 5 commits October 5, 2022 13:58

Updated tests

0e210d7

Merge branch 'mtewani/exponential-backoff-2' of https://github.com/fi…

88751fd

…rebase/firebase-js-sdk into mtewani/exponential-backoff-2

Actually removed a comment

7e5933d

Included small oneshot upload request

4488c44

Update API reports

f107589

tonyjhuang approved these changes Oct 5, 2022

View reviewed changes

packages/storage/src/implementation/constants.ts Outdated Show resolved Hide resolved

maneesht added 3 commits October 5, 2022 23:00

Added one more test for smaller uploads

5e33f72

Merge branch 'mtewani/exponential-backoff-2' of https://github.com/fi…

431a202

…rebase/firebase-js-sdk into mtewani/exponential-backoff-2

Removed log

0f17b6b

maneesht requested a review from Yuangwang October 6, 2022 06:06

Yuangwang approved these changes Oct 6, 2022

View reviewed changes

maneesht added 2 commits October 6, 2022 08:42

Updated comment

6d3d755

Removed comment from api

bd2d6ac

egilmorez requested a review from markarndt October 6, 2022 16:21

markarndt approved these changes Oct 6, 2022

View reviewed changes

packages/storage/src/implementation/backoff.ts Outdated Show resolved Hide resolved

Added punctuation

05fa51b

egilmorez approved these changes Oct 6, 2022

View reviewed changes

hsubox76 approved these changes Oct 6, 2022

View reviewed changes

maneesht merged commit 4eb8145 into master Oct 6, 2022

maneesht deleted the mtewani/exponential-backoff-2 branch October 6, 2022 19:53

google-oss-bot mentioned this pull request Oct 10, 2022

Version Packages #6672

Merged

firebase locked and limited conversation to collaborators Nov 6, 2022

Implemented exponential backoff with query #6653

Implemented exponential backoff with query #6653

Conversation

maneesht commented Oct 4, 2022

changeset-bot bot commented Oct 4, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented Oct 4, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/storage

bundle

firebase

Test Logs

google-oss-bot commented Oct 4, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/storage

StringFormat

_FbsBlob

_Location

_TaskEvent

_TaskState

_UploadTask

_dataFromString

_getChild

_invalidArgument

_invalidRootOperation

connectStorageEmulator

deleteObject

getBlob

getBytes

getDownloadURL

getMetadata

getStorage

getStream

list

listAll

ref

updateMetadata

uploadBytes

uploadBytesResumable

uploadString

Test Logs

tonyjhuang left a comment

Choose a reason for hiding this comment

Yuangwang commented Oct 6, 2022

egilmorez left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 4, 2022 •

edited

Loading

google-oss-bot commented Oct 4, 2022 •

edited

Loading

Size Report ¹

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented Oct 4, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/storage`

`StringFormat`

`_FbsBlob`

`_Location`

`_TaskEvent`

`_TaskState`

`_UploadTask`

`_dataFromString`

`_getChild`

`_invalidArgument`

`_invalidRootOperation`

`connectStorageEmulator`

`deleteObject`

`getBlob`

`getBytes`

`getDownloadURL`

`getMetadata`

`getStorage`

`getStream`

`list`

`listAll`

`ref`

`updateMetadata`

`uploadBytes`

`uploadBytesResumable`

`uploadString`