Make COUNT queries available to the Firestore Console #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 58a29f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
dconeybe
changed the title
|
@egilmorez PTAL as a required reviewer. Thanks! |
markarndt
approved these changes
Oct 6, 2022
egilmorez
approved these changes
Oct 6, 2022
|
Pardon me but what is this function? It seem like it is a very significant feature yet I have not seen any documents about it |
|
We will be talking about this feature more in the coming weeks. Stay tuned! |
Merged
|
@Thaina Please see https://cloud.google.com/blog/products/databases/aggregating-data-with-firestore for full details about this new feature :) |
|
Thank you very much
Sadly still not available in unity sdk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two notable changes in this PR:
XhrIo.setWithCredentials(true)when invoking theRunAggregationQueryRPC.getCountFromServer()in theINTERNALobject.The
XhrIo.setWithCredentials(true)change is required so that the Firestore Console's authentication cookie will be included in the HTTP request headers. Without it, the requests fail with HTTP 401 errors. This problem is unique to the Firestore Console because they use 1st-party authentication. This change should have no effect on any other users. Moreover, the "Listen" and "Write" streams have been invokingXhrIo.setWithCredentials(true)indirectly since the dawn of time by specifyingsupportsCrossDomainXhr: truein theWebChannelOptions:firebase-js-sdk/packages/firestore/src/platform/browser/webchannel_connection.ts
Line 179 in 34ad43c
XhrIo.setWithCredentials(true)here: https://github.com/google/closure-library/blob/e439bfd5ff09e0efd85693fc5adf23462d5a39d4/closure/goog/labs/net/webchannel/webchannelbase.js#L2601The change to the firestore-compat library is done because the Firestore Console is stuck using the compat SDK for now, and we don't want to add a new public API surface to the firestore-compat library.
Googlers see b/250662155 for more info.