Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Field type reference in QueryDocumentSnapshot is not an instance of DocumentReference #4125

Closed
mandalornl opened this issue Nov 26, 2020 · 1 comment · Fixed by #4136
Closed

[Bug] Field type reference in QueryDocumentSnapshot is not an instance of DocumentReference #4125

mandalornl opened this issue Nov 26, 2020 · 1 comment · Fixed by #4136
Assignees
@schmidt-sebastian
Labels
api: firestore

Comments

@mandalornl
Copy link

[REQUIRED] Describe your environment

  • Operating System version: Ubuntu 20.04
  • Browser version: Chrome 86
  • Firebase SDK version: ^8.1.0
  • Firebase Product: firestore

[REQUIRED] Describe the problem

When querying documents from a collection, the field type reference does not return an instance of DocumentReference anymore. Therefore calling e.g. get() will result in an is not a function error. Example code can be found in the link below.

Relevant Code:

https://stackblitz.com/edit/firebase-issue-sandbox-z9mwhw
@dconeybe
Copy link
Contributor

Thank you for reporting this issue. The stackblitz link was super helpful! At first glance, this definitely appears to be a regression in 8.1.0 (compared to 8.0.2). I'll do some investigation and reply back. Just a heads-up, since it's a long weekend in the US, I may not have a meaningful response until next week.

Foxhunt added a commit to Foxhunt/kronos that referenced this issue Nov 29, 2020
@Foxhunt
Revert firebase update due to bug
0e08d9b 
firebase/firebase-js-sdk#4125
@dconeybe dconeybe mentioned this issue Nov 30, 2020
Closed
@posva posva mentioned this issue Nov 30, 2020
Merged
@schmidt-sebastian schmidt-sebastian mentioned this issue Nov 30, 2020
Merged
@jamesdaniels jamesdaniels mentioned this issue Nov 30, 2020
Closed
@google-oss-bot google-oss-bot mentioned this issue Dec 2, 2020
Merged
@fgatti675 fgatti675 mentioned this issue Dec 4, 2020
Closed
@rulamon rulamon mentioned this issue Dec 18, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return Firestore-Compat types from QuerySnapshot.docs firebase/firebase-js-sdk
4 participants
@schmidt-sebastian @google-oss-bot @mandalornl @dconeybe